Tue, 27 Jul 2010 21:17:01 +0000
Stop using custom encodings (and LATIN-1, for that matter) for sending
OSCAR messages (ICBM, chat, Direct IM). Now, we use ASCII if a message
contains ASCII characters only, and UTF-16 in all other cases.
That fixes #10833 (offline messages now will be sent as UTF-16)
and also a whole bunch of potential problems we can get
with charset 0x3. Different clients tend to interpret this
charset differently; for instance, the official client
always interprets it as LATIN-1, while alternative
clients may decode it as some other user-specified
8-bit encoding. On the other hand, ASCII messages
(charset 0x0) and UTF-16 messages (charset 0x2) are understood
uniformly by all clients.
I also cleaned-up the code a little (got rid of code paths that were
never executed, flags that were always set, unused struct members, etc.)
/* * Purple's oscar protocol plugin * This file is the legal property of its developers. * Please see the AUTHORS file distributed alongside this file. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 2 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _ENCODING_H_ #define _ENCODING_H_ #include "oscar.h" #include "oscarcommon.h" /** * Determine the simplest encoding we can send this message in. */ guint16 oscar_charset_check(const char *utf8); /** * Take a string of the form charset="bleh" where bleh is * one of us-ascii, utf-8, iso-8859-1, or unicode-2-0, and * return a newly allocated string containing bleh. */ gchar * oscar_encoding_extract(const char *encoding); gchar * oscar_encoding_to_utf8(PurpleAccount *account, const char *encoding, const char *text, int textlen); gchar * oscar_utf8_try_convert(PurpleAccount *account, OscarData *od, const gchar *msg); /** * This attemps to decode an incoming IM into a UTF8 string. * * We try decoding using two different character sets. The charset * specified in the IM determines the order in which we attempt to * decode. We do this because there are lots of broken ICQ clients * that don't correctly send non-ASCII messages. And if Purple isn't * able to deal with that crap, then people complain like banshees. */ gchar * oscar_decode_im_part(PurpleAccount *account, const char *sourcebn, guint16 charset, guint16 charsubset, const gchar *data, gsize datalen); /** * Figure out what encoding to use when sending a given outgoing message. */ gchar * oscar_convert_to_best_encoding(const gchar *msg, gsize *result_len, guint16 *charset, gchar **charsetstr); #endif