Tue, 15 Oct 2024 00:47:42 -0500
Port prefs to AdwSwitchRow
Now that we depend on Adwaita 1.4, we can flip the switch on using these (pun intended).
This also simplifies some extra tracking we needed to do for activations and focus, since the Adwaita widgets do that for us.
Testing Done:
Opened prefs, confirmed all the switches were there, and toggled them all without any warnings.
Also used the mnemonics to toggle the switches from the keyboard.
Reviewed at https://reviews.imfreedom.org/r/3582/
<?xml version="1.0" encoding="UTF-8"?> <!-- Pidgin - Internet Messenger Copyright (C) Pidgin Developers <devel@pidgin.im> This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, see <https://www.gnu.org/licenses/>. --> <interface> <requires lib="gtk" version="4.0"/> <requires lib="Adw" version="1.0"/> <!-- interface-license-type gplv2 --> <!-- interface-name Pidgin --> <!-- interface-description Internet Messenger --> <!-- interface-copyright Pidgin Developers <devel@pidgin.im> --> <object class="GtkAdjustment" id="ports_range_end.adjustment"> <property name="upper">65535</property> <property name="step-increment">1</property> <property name="page-increment">10</property> </object> <object class="GtkAdjustment" id="ports_range_start.adjustment"> <property name="upper">65535</property> <property name="step-increment">1</property> <property name="page-increment">10</property> </object> <template class="PidginNetworkPrefs" parent="AdwPreferencesPage"> <child> <object class="AdwPreferencesGroup"> <property name="title" translatable="1">IP Address</property> <child> <object class="AdwEntryRow" id="stun_server"> <property name="title" translatable="1">ST_UN server</property> <property name="use-underline">1</property> <property name="input-purpose">url</property> </object> </child> <child> <object class="AdwSwitchRow" id="auto_ip"> <property name="title" translatable="1">Use _automatically detected IP address</property> <property name="use-underline">1</property> <signal name="notify::active" handler="auto_ip_button_clicked_cb" after="yes" swapped="no"/> </object> </child> <child> <object class="AdwEntryRow" id="public_ip"> <property name="title" translatable="1">Public _IP</property> <property name="use-underline">1</property> <property name="sensitive" bind-source="auto_ip" bind-property="active" bind-flags="sync-create|invert-boolean">0</property> <signal name="changed" handler="network_ip_changed" swapped="no"/> </object> </child> </object> </child> <child> <object class="AdwPreferencesGroup"> <property name="title" translatable="1">Ports</property> <child> <object class="AdwSwitchRow" id="map_ports"> <property name="title" translatable="1">_Enable automatic router port forwarding</property> <property name="use-underline">1</property> </object> </child> <child> <object class="AdwExpanderRow" id="ports_range_use"> <property name="title" translatable="1">_Manually specify range of ports to listen on</property> <property name="show-enable-switch">1</property> <property name="use-underline">1</property> <property name="focusable">0</property> <child> <object class="AdwActionRow"> <property name="activatable-widget">ports_range_start</property> <property name="title" translatable="1">_Start</property> <property name="use-underline">1</property> <property name="focusable">0</property> <child> <object class="GtkSpinButton" id="ports_range_start"> <property name="focusable">1</property> <property name="valign">center</property> <property name="text" translatable="1">0</property> <property name="adjustment">ports_range_start.adjustment</property> <property name="numeric">1</property> </object> </child> </object> </child> <child> <object class="AdwActionRow"> <property name="activatable-widget">ports_range_end</property> <property name="title" translatable="1">_End</property> <property name="use-underline">1</property> <property name="focusable">0</property> <child> <object class="GtkSpinButton" id="ports_range_end"> <property name="focusable">1</property> <property name="valign">center</property> <property name="text" translatable="1">0</property> <property name="adjustment">ports_range_end.adjustment</property> <property name="numeric">1</property> </object> </child> </object> </child> </object> </child> </object> </child> </template> </interface>