Thu, 22 Jul 2021 22:33:54 -0500
Move minidialog stuff from utils to its source file
* Remove minidialog list from utils.
It's supposed to be used to delete them when the connection is dropped, but this list is never added to. And the dialogs are automatically closed when the account disconnects in some other way that I could not find.
Consequently, drop the unused `gc` from `pidgin_make_mini_dialog*`.
* Replace `PidginUtilMiniDialogCallback` by `PidginMiniDialogCallback`.
It is just a wrapper around the latter, with different argument order.
* Move minidialog wrappers from utils to `minidialog.c`. And fix naming/arguments to match the existing functions.
Testing Done:
Compiled, connected an account that had buddy requests, but didn't act on them.
Reviewed at https://reviews.imfreedom.org/r/788/
/* * Pidgin - Internet Messenger * Copyright (C) Pidgin Developers <devel@pidgin.im> * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, see <https://www.gnu.org/licenses/>. */ #if !defined(PIDGIN_GLOBAL_HEADER_INSIDE) && !defined(PIDGIN_COMPILATION) # error "only <pidgin.h> may be included directly" #endif #ifndef PIDGIN_SCROLL_BOOK_H #define PIDGIN_SCROLL_BOOK_H /** * SECTION:pidginscrollbook * @section_id: pidgin-pidginscrollbook * @title: Scrolling Notebook Widget * * This widget is used to show error messages in the buddy list window. */ #include <gtk/gtk.h> G_BEGIN_DECLS #define PIDGIN_TYPE_SCROLL_BOOK (pidgin_scroll_book_get_type ()) G_DECLARE_FINAL_TYPE(PidginScrollBook, pidgin_scroll_book, PIDGIN, SCROLL_BOOK, GtkBox) /** * pidgin_scroll_book_new: * * Creates a new #PidginScrollBook. * * Returns: (transfer full): The new #PidginScrollBook instance. */ GtkWidget *pidgin_scroll_book_new(void); /** * pidgin_scroll_book_get_notebook: * @scroll_book: The #PidginScrollBook instance. * * Gets the notebook widget from @scroll_book. * * Returns: (transfer none): The notebook inside of @scroll_book. */ GtkWidget *pidgin_scroll_book_get_notebook(PidginScrollBook *scroll_book); G_END_DECLS #endif /* PIDGIN_SCROLL_BOOK_H */