pidgin/pidgintalkatu.h@f33f4713508b
pidgin/pidgintalkatu.h
Tue, 22 Mar 2022 03:53:15 -0500
- author
- Elliott Sales de Andrade <quantum.analyst@gmail.com>
- date
- Tue, 22 Mar 2022 03:53:15 -0500
- changeset 41309
- f33f4713508b
- parent 41124
- 95555046173e
- permissions
- -rw-r--r--
Don't set some PurpleBuddy properties at construction time
These properties don't appear to be read at construction time, and in fact
their setter accesses `priv->account`, which is not yet set, causing some
critical warnings.
Testing Done:
Ran with demo prpl and no longer have this critical:
```
(pidgin3:1123375): Purple-CRITICAL **: 02:45:40.007: purple_conversation_manager_find_im: assertion 'PURPLE_IS_ACCOUNT(account)' failed
```
Reviewed at https://reviews.imfreedom.org/r/1361/
/* pidgin * * Pidgin is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #if !defined(PIDGIN_GLOBAL_HEADER_INSIDE) && !defined(PIDGIN_COMPILATION) # error "only <pidgin.h> may be included directly" #endif #ifndef PIDGIN_TALKATU_H #define PIDGIN_TALKATU_H #include <gtk/gtk.h> #include <talkatu.h> #include <purple.h> G_BEGIN_DECLS /** * pidgin_talkatu_editor_new_for_connection: * @pc: The connection for which the editor should be created * * Creates a new #TalkatuEditor appropriate for use with @pc. * * Returns: (transfer full): the new #TalkatuEditor */ GtkWidget *pidgin_talkatu_editor_new_for_connection(PurpleConnection *pc); /** * pidgin_talkatu_buffer_new_for_connection: * @pc: The connection for which the buffer should be created * * Creates a new #TalkatuBuffer. Depending on @pc's #PurpleConnectionFlags, * it will create a plain, HTML, or markdown buffer. * * Returns: (transfer full): the new #TalkatuBuffer */ GtkTextBuffer *pidgin_talkatu_buffer_new_for_connection(PurpleConnection *pc); G_END_DECLS #endif /* PIDGIN_TALKATU_H */
