Wed, 19 Oct 2022 06:25:35 -0500
Back out the PurpleProtocol->login change that returned a PurpleConnection
This remains to be a good idea, but this implementation caused more issues than
it solved. I'm working on that better implementation, but we need to revert all
of this first, otherwise the new review request is going to be massive.
This reverts commits 3f96e2b2b03d, d567f89d6a9b, and 6ef5bb284651. These were
backed out manually due to some other commits that made automative backouts
difficult.
Testing Done:
Connected a demo, ircv3, and xmpp accounts without issue.
Reviewed at https://reviews.imfreedom.org/r/1937/
/* purple * * Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * Rewritten from scratch during Google Summer of Code 2012 * by Tomek Wasilczyk (http://www.wasilczyk.pl). * * Previously implemented by: * - Arkadiusz Miskiewicz <misiek@pld.org.pl> - first implementation (2001); * - Bartosz Oler <bartosz@bzimage.us> - reimplemented during GSoC 2005; * - Krzysztof Klinikowski <grommasher@gmail.com> - some parts (2009-2011). * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef PURPLE_GG_XML_H #define PURPLE_GG_XML_H #include <purple.h> gboolean ggp_xml_get_string(const PurpleXmlNode *xml, const gchar *childName, gchar **var); gboolean ggp_xml_get_bool(const PurpleXmlNode *xml, const gchar *childName, gboolean *var); gboolean ggp_xml_get_uint(const PurpleXmlNode *xml, const gchar *childName, unsigned int *var); gboolean ggp_xml_set_string(PurpleXmlNode *xml, const gchar *childName, const gchar *val); gboolean ggp_xml_set_bool(PurpleXmlNode *xml, const gchar *childName, gboolean val); gboolean ggp_xml_set_uint(PurpleXmlNode *xml, const gchar *childName, unsigned int val); void ggp_xmlnode_remove_children(PurpleXmlNode *xml); unsigned int ggp_xml_child_count(PurpleXmlNode *xml, const gchar *childName); #endif /* PURPLE_GG_XML_H */