Fri, 17 Nov 2006 06:12:17 +0000
[gaim-migrate @ 17767]
Ari Pollak traced down a memory leak to the account menuitems not being cleaned up by gtk_container_remove().
It turns out that there is an additional reference somewhere which is preventing the menuitem from being destroyed - deryni tracked it down to gtk_accel_label_set_accel_widget() in gtk_image_menu_item_new_with_label() - we will be reporting the bug to the GTK folks tomorrow.
This fixes the leakage; gtk_widget_destroy() is what really should be used in this situation anyway.
/** * @file gntconn.c GNT Connection API * @ingroup gntui * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "notify.h" #include "gntconn.h" #include "gntgaim.h" static void gg_connection_report_disconnect(GaimConnection *gc, const char *text) { char *act, *primary, *secondary; GaimAccount *account = gaim_connection_get_account(gc); act = g_strdup_printf(_("%s (%s)"), gaim_account_get_username(account), gaim_account_get_protocol_name(account)); primary = g_strdup_printf(_("%s disconnected."), act); secondary = g_strdup_printf(_("%s was disconnected due to the following error:\n%s"), act, text); gaim_notify_error(account, _("Connection Error"), primary, secondary); g_free(act); g_free(primary); g_free(secondary); } static GaimConnectionUiOps ops = { .connect_progress = NULL, .connected = NULL, .disconnected = NULL, .notice = NULL, .report_disconnect = gg_connection_report_disconnect }; GaimConnectionUiOps *gg_connections_get_ui_ops() { return &ops; } void gg_connections_init() {} void gg_connections_uninit() {}