pidgin/plugins/xmppconsole/meson.build

Mon, 05 Sep 2022 23:36:14 -0500

author
Elliott Sales de Andrade <quantum.analyst@gmail.com>
date
Mon, 05 Sep 2022 23:36:14 -0500
changeset 41652
fd32ea10d1cb
parent 41116
dff0811ff40c
child 42468
3ea8d5befbe4
permissions
-rw-r--r--

Modernize XMPP console a bit

Convert `GtkComboBox` to `GtkDropDown`.

Changed the invalid XML entry to use error underline instead of the custom CSS background. Unfortunately, the upstream `error` CSS does not apply to a `TextView `, so this was the better alternative.

Fixed alignment on the `<iq>` popover.

Add a bit of vertical padding and suggested action CSS in popovers.

Inline some objects in the .ui now that `<property>` can contain children.
Consequently, the popover is closed with `gtk_menu_button_popdown` instead of `gtk_popover_popdown`. I don't know if it makes a difference, but it _seems_ better to use the parent's method instead of the child's.

Testing Done:
Opened XMPP console, picked some of the automated entries, changed to invalid XML to check the invalid styling.

Reviewed at https://reviews.imfreedom.org/r/1714/

xmppconsole_resource = gnome.compile_resources('xmppconsoleresources',
    'xmppconsole.gresource.xml',
    c_name : 'xmppconsole')

library('xmppconsole',
    'xmppconsole.c', xmppconsole_resource,
    c_args : ['-DG_LOG_USE_STRUCTURED', '-DG_LOG_DOMAIN="PidginPlugin-XMPPConsole"'],
    dependencies : [libpurple_dep, libpidgin_dep, glib],
    name_prefix : '',
    install : true, install_dir : PIDGIN_PLUGINDIR)

devenv.append('PIDGIN_PLUGIN_PATH', meson.current_build_dir())

mercurial