changelog
- Sat, 09 Aug 2025 17:37:27 +0800
- by Gong Zhile <gongzl@stu.hebust.edu.cn> [Sat, 09 Aug 2025 17:37:27 +0800] rev 43304
- Fix the birb header path
The birb header referred would only work with birb provided by wrap casuing
build to fail because of system-installed birb dependency. The commit points
it to the correct path <birb.h>.
See: https://keep.imfreedom.org/birb/birb/file/5bf00c7d7f80/birb/meson.build#l77
- Sat, 09 Aug 2025 02:43:31 -0500
- by Gary Kramlich <grim@reaperworld.com> [Sat, 09 Aug 2025 02:43:31 -0500] rev 43303
- Fix some broken logic in Purple.Conversation.send_message_async
The callback was doing some nonsense trying to give the user an error if
Purple.ProtocolConversation.send_message_async returned false without setting
error. This was then clearing the error using g_clear_error even if error was
set, but G.Task.return_error takes ownership of the error which is what lead
to the crash.
This wasn't caught by the unit tests because we don't have a test for
purple_conversation_send_message_async and
purple_conversation_send_message_finish. We should add one at some point as we
also weren't exposing purple_conversation_send_message_finish which I
discovered while debugging this.
Anyways, we should implement a unit test for this but it needs a protocol
as well and I didn't want to bother with this right now as the fix is more
important.
Testing Done:
Modified the demo protocol to return errors and verified the crash was gone. Reverted that and verified that sending messages worked.
Also called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/4095/
- Thu, 07 Aug 2025 21:40:13 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 07 Aug 2025 21:40:13 -0500] rev 43302
- Add an avatar-for-display property to Purple.ContactInfo
Testing Done:
Ran the tests under valgrind and called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/4086/
- Thu, 07 Aug 2025 21:34:33 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 07 Aug 2025 21:34:33 -0500] rev 43301
- Replace Purple.Avatar with Purple.Image
Purple.Avatar was unnecessary and this just moves everything to Purple.Image
which should work just fine.
Testing Done:
Loaded a demo account and verified that the avatars were shown in the contact list properly. Also called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/4084/
- Thu, 07 Aug 2025 21:32:18 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 07 Aug 2025 21:32:18 -0500] rev 43300
- Clean up and modernize PurpleImage
Testing Done:
Ran the tests under valgrind and called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/4074/
- Thu, 31 Jul 2025 20:57:19 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 31 Jul 2025 20:57:19 -0500] rev 43299
- Remove Purple.CircularBuffer
This was primarily used for file transfer, which should be using GIOStreams
instead.
Testing Done:
Called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/4083/
- Thu, 31 Jul 2025 20:55:42 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 31 Jul 2025 20:55:42 -0500] rev 43298
- Silence a warning the sip protocol skeleton
Testing Done:
Compiled and verified that the warning was gone.
Reviewed at https://reviews.imfreedom.org/r/4082/
- Thu, 31 Jul 2025 16:57:17 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 31 Jul 2025 16:57:17 -0500] rev 43297
- Use the presence message of a contact for the subtitle of DM's
Testing Done:
Loaded a demo account and opened a conversation with someone that has a status message and also verified that the topic was still shown for IRC channels.
And of course, called in the turtles as well.
Reviewed at https://reviews.imfreedom.org/r/4081/
- Thu, 31 Jul 2025 16:55:45 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 31 Jul 2025 16:55:45 -0500] rev 43296
- Remove searching from Purple.ProtocolContacts
This is being moved to Purple.ProtocolDirectory and being implemented in a
different way.
Testing Done:
Called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/4078/
- Thu, 31 Jul 2025 16:54:02 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 31 Jul 2025 16:54:02 -0500] rev 43295
- Delete the purple_gdk_pixbuf api
GdkPixbuf is kind of being deprecated and we really shouldn't use it in new
code. Luckily a lot of this straight forward to move away from it.
Testing Done:
Called in the turtles and tested the request api with the demo protocol plugin.
Reviewed at https://reviews.imfreedom.org/r/4075/
