changelog
- Mon, 03 Feb 2025 21:11:44 -0600
- by Gary Kramlich <grim@reaperworld.com> [Mon, 03 Feb 2025 21:11:44 -0600] rev 43173
- Implement searching the conversation members
This replaces the label that showed how many members are in the conversation
but that text is now used as the placeholder text in the search widget.
Testing Done:
Joined a channel on a local ergo server and tested a few matches.
Bugs closed: PIDGIN-18039
Reviewed at https://reviews.imfreedom.org/r/3808/
- Mon, 03 Feb 2025 21:09:03 -0600
- by Gary Kramlich <grim@reaperworld.com> [Mon, 03 Feb 2025 21:09:03 -0600] rev 43172
- Add Purple.ConversationMember.matches
This will be useful for searching member lists and maybe some other stuff.
Testing Done:
Ran the unit tests under valgrind and called in the turtles.
Bugs closed: PIDGIN-18038
Reviewed at https://reviews.imfreedom.org/r/3807/
- Mon, 03 Feb 2025 21:07:27 -0600
- by Gary Kramlich <grim@reaperworld.com> [Mon, 03 Feb 2025 21:07:27 -0600] rev 43171
- Update the tests for Purple.Person
I also added Purple.Person.remove_all_contact_infos as we need it for the
tests and it could be useful for others maybe.
Testing Done:
Ran the tests under valgrind and called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/3795/
- Sat, 01 Feb 2025 01:23:37 -0600
- by Gary Kramlich <grim@reaperworld.com> [Sat, 01 Feb 2025 01:23:37 -0600] rev 43170
- IRCv3: Don't attempt to join the status window when connecting
Testing Done:
Connected and verified I didn't see a `JOIN devenv 192.168.1.220` and a `403` reply from the server in ngrep.
Reviewed at https://reviews.imfreedom.org/r/3803/
- Sat, 01 Feb 2025 00:22:07 -0600
- by Gary Kramlich <grim@reaperworld.com> [Sat, 01 Feb 2025 00:22:07 -0600] rev 43169
- IRCv3: Require Ibis 0.11.1
This release fixes a bunch of bugs and will try an alternate nick if necessary
so we wanted to use it immediately.
Testing Done:
Cleaned all my sub projects and then called in the turtles.
Reviewed at https://reviews.imfreedom.org/r/3802/
- Fri, 31 Jan 2025 23:42:38 -0600
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 31 Jan 2025 23:42:38 -0600] rev 43168
- Fix indent of purple_unescape_text
It was 4-space instead of tabs.
Testing Done:
Compiled only.
Reviewed at https://reviews.imfreedom.org/r/3799/
- Fri, 31 Jan 2025 23:14:52 -0600
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 31 Jan 2025 23:14:52 -0600] rev 43167
- ircv3: Remove another redundant account disconnection
When `ibis_client_stop` is called, it will set `IbisClient:connect` to `FALSE` and `IbisClient:error` to the input error.
The IRCv3 protocol's `notify` handler for the first one disconnects the account, so the `notify` handler for the latter should _not_ also disconnect the account. It is sufficient to just set the account error.
Testing Done:
Connected to a IRC that kicked me, and didn't see any warning about `purple_account_disconnect` being called when already disconnected.
Reviewed at https://reviews.imfreedom.org/r/3797/
- Fri, 31 Jan 2025 01:46:37 -0600
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 31 Jan 2025 01:46:37 -0600] rev 43166
- Fix reloading of account errors
As of /r/3575, saving an account error to `accounts.xml` converts the quark to a string, but reading it back incorrectly tries to parse it as an integer.
Testing Done:
Reloaded an account with an error and didn't see a warning about `GError` with 0 domain.
Reviewed at https://reviews.imfreedom.org/r/3796/
- Thu, 30 Jan 2025 23:59:09 -0600
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Thu, 30 Jan 2025 23:59:09 -0600] rev 43165
- ircv3: Remove redundant account disconnection
If an `error` is set on the `IbisClient`, then the `notify::error` handler `purple_ircv3_connection_error_cb` will disconnect the account with that error.
So in `purple_ircv3_message_handler_error_cb`, pass the error to `ibis_client_stop`. This shouldn't change anything except remove the duplicate implementation of disconnecting the account.
Testing Done:
Compiled and turtles only. I did try `PIDGIN-18031`, but it didn't fix it.
Reviewed at https://reviews.imfreedom.org/r/3794/
- Thu, 30 Jan 2025 22:25:41 -0600
- by Gary Kramlich <grim@reaperworld.com> [Thu, 30 Jan 2025 22:25:41 -0600] rev 43164
- Add Purple.CreateConversationDetails.is_valid
This does some basic checking and creates standard errors for invalid settings
on Purple.CreateConversationDetails.
Testing Done:
Ran the unit tests under valgrind and called in the turtles as well.
Bugs closed: PIDGIN-18032
Reviewed at https://reviews.imfreedom.org/r/3791/
