changelog
- Mon, 18 Jul 2022 20:46:36 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 18 Jul 2022 20:46:36 -0500] rev 41446
- Remove purple_account_notify_added as it isn't used by anyone.
I used the new plugins-ansible repo to clone all known plugins and saw that it
was only used in the classic battlenet plugin which is no long maintained and
according to its issue tracker hasn't worked for a long time.
Testing Done:
Compiled
Reviewed at https://reviews.imfreedom.org/r/1526/
- Wed, 06 Jul 2022 05:47:52 -0500
- by Gary Kramlich <grim@reaperworld.com> [Wed, 06 Jul 2022 05:47:52 -0500] rev 41445
- Remove the account error scrollbook from the blist as notifications have replaced it.
Also clear account errors when we attempt a new connection which made clearing
the errors after the account has connected redundant.
Testing Done:
Caused the same account to get disconnected between pidgin 2 and 3 to verify notifications were working as expected.
Bugs closed: PIDGIN-17640
Reviewed at https://reviews.imfreedom.org/r/1521/
- Tue, 05 Jul 2022 02:03:30 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 05 Jul 2022 02:03:30 -0500] rev 41444
- Properly set an account's current error.
This is a regression from 86beaec0fa35 which caused a crash when an account got
disabled because it was logged in elsewhere.
Testing Done:
Ran locally and had pidgin2 and pidgin3 boot each other a few times.
Reviewed at https://reviews.imfreedom.org/r/1520/
- Tue, 05 Jul 2022 01:59:42 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 05 Jul 2022 01:59:42 -0500] rev 41443
- Use a HdyStatusPage as a place holder for conversations
Testing Done:
Ran locally.
Reviewed at https://reviews.imfreedom.org/r/1519/
- Tue, 05 Jul 2022 00:06:54 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 05 Jul 2022 00:06:54 -0500] rev 41442
- Use a HdyStatusPage as a place holder for the notifications list
Testing Done:
Ran locally.
Reviewed at https://reviews.imfreedom.org/r/1518/
- Mon, 04 Jul 2022 23:24:35 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 04 Jul 2022 23:24:35 -0500] rev 41441
- Implement the UI for the new Notifications API.
This currently only shows connection error notifications which have to be
removed manually since an account with a connection error can not currently
reconnect successfully.
Testing Done:
I used a IRC account with an server name that was unresolvable as well as an XMPP account with a wrong password to cause a fatal connection errors.
I also used a IRC account connecting to a local instance of ZNC where I terminated ZNC to cause a server side connection failure.
Bugs closed: PIDGIN-17634
Reviewed at https://reviews.imfreedom.org/r/1512/
- Mon, 04 Jul 2022 20:29:32 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Mon, 04 Jul 2022 20:29:32 -0500] rev 41440
- Use GtkEventControllerKey in the buddy list.
I've had this sitting around for a year, so might as well post it before this file gets deleted.
Also includes a bit of variable cleanup to shorten lines.
Testing Done:
Compile only.
Reviewed at https://reviews.imfreedom.org/r/1513/
- Mon, 04 Jul 2022 20:20:05 -0500
- by ivanhoe <ivanhoe@fiscari.de> [Mon, 04 Jul 2022 20:20:05 -0500] rev 41439
- handle GTK_RESPONSE_DELETE_EVENT when closing account manager via window manager
Testing Done:
Ran Pidgin and closed the account manager with the X button of the window manager.
Reviewed at https://reviews.imfreedom.org/r/1515/
- Thu, 30 Jun 2022 20:24:09 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 30 Jun 2022 20:24:09 -0500] rev 41438
- Create and add notifications for account errors.
Adjust the NotificationManager API a bit to be easier to use and map better to
GListStore which the manager is now using internally.
Testing Done:
Ran the unit tests and forced a connection error and verified no issues (used gdb to verify that item was added).
Bugs closed: PIDGIN-17639
Reviewed at https://reviews.imfreedom.org/r/1509/
- Tue, 28 Jun 2022 16:04:47 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Tue, 28 Jun 2022 16:04:47 -0500] rev 41437
- Add a protocol actions interface
Testing Done:
Compile only, for this part by itself.
Reviewed at https://reviews.imfreedom.org/r/1511/