changelog
- Thu, 03 May 2018 18:17:21 -0500
- by Mike Ruprecht <cmaiku@gmail.com> [Thu, 03 May 2018 18:17:21 -0500] rev 39005
- xfer: Rename PurpleProtocolXferInterface.send() to send_file()
With the addition of PurpleProtocolXferInterface, building in Windows
fails due to the redefinition of send() as wpurple_send(). Since a
lot of the prpls already call it this their implementations, this
patch renames it to send_file(). This fixes building on Windows
again.
- Fri, 04 May 2018 01:55:36 +0000
- by Gary Kramlich <grim@reaperworld.com> [Fri, 04 May 2018 01:55:36 +0000] rev 39004
- Merged in qulogic/pidgin (pull request #328)
Convert XMPP console plugin to plain GtkTextView
Approved-by: Gary Kramlich <grim@reaperworld.com>
Approved-by: Eion Robb <eionrobb@gmail.com>
- Sat, 28 Apr 2018 03:44:22 -0400
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Sat, 28 Apr 2018 03:44:22 -0400] rev 39003
- Restore XML indenting in XMPP console.
- Sat, 28 Apr 2018 03:39:59 -0400
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Sat, 28 Apr 2018 03:39:59 -0400] rev 39002
- Remove deprecated stock icons from XMPP console.
- Sat, 28 Apr 2018 02:18:26 -0400
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Sat, 28 Apr 2018 02:18:26 -0400] rev 39001
- Convert XMPP console display to GtkTextView.
It does not really need much in the way of special formatting or
interactivity that it needs to use a full GtkWebView.
- Sat, 28 Apr 2018 01:06:53 -0400
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Sat, 28 Apr 2018 01:06:53 -0400] rev 39000
- Use GtkTextView for XMPP console entry.
There's not really any formatting involved here.
- Sat, 28 Apr 2018 01:01:07 -0400
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Sat, 28 Apr 2018 01:01:07 -0400] rev 38999
- Fix leak when using XMPP console templates.
- Thu, 03 May 2018 11:26:30 -0500
- by Mike Ruprecht <cmaiku@gmail.com> [Thu, 03 May 2018 11:26:30 -0500] rev 38998
- util: Write files with permission mode 0600 again
My previous patch to simplify purple_util_write_data_to_file_absolute()
wrote files with permission mode 0666, modified by whatever permission
the umask allowed (on my machine this is 0644). The old code used
with 0600.
This patch replaces g_file_set_contents(), which has no choice but to
use 0666, with g_file_replace_contents(), which has the flag
G_FILE_CREATE_PRIVATE to use 0600.
The patch also calculates the strlen() if size is -1 and guards
against any values less than that as g_file_replace_contents() takes
an unsigned length and therefore can't calculate it itself.
- Tue, 24 Apr 2018 23:33:44 -0500
- by Mike Ruprecht <cmaiku@gmail.com> [Tue, 24 Apr 2018 23:33:44 -0500] rev 38997
- meson: Remove now unused HAVE_FILENO check
- Tue, 24 Apr 2018 23:32:23 -0500
- by Mike Ruprecht <cmaiku@gmail.com> [Tue, 24 Apr 2018 23:32:23 -0500] rev 38996
- util: Simplify purple_util_write_data_to_file_absolute()
This patch replaces the contents of
purple_util_write_data_to_file_absolute() with g_file_set_contents().
I compared the two functions and it seems the only things the latter
doesn't do that the former does is:
1: use fflush()
2: explicitly check that the file size matches what was requested
g_file_set_contents() used to use fflush(), but was changed to use
write() instead of fwrite() so it's possible that eliminates the need?
I expect it should also be fine that it doesn't explicitly check the
file size separately either these days.
