changelog
- Fri, 10 Feb 2023 03:00:58 -0600
- by Gary Kramlich <grim@reaperworld.com> [Fri, 10 Feb 2023 03:00:58 -0600] rev 42053
- Add a name-for-display property to PurplePerson
This will first return the alias of the person if set. If there is no alias set
on the person but there is a priority contact info, the value of
purple_contact_info_get_name_for_display will be called on the priority contact
info, otherwise NULL will be returned.
Testing Done:
Verified everything looked right in the contact list and verified everything looked alright in the docs and ran the unit tests.
Reviewed at https://reviews.imfreedom.org/r/2205/
- Fri, 10 Feb 2023 00:59:09 -0600
- by Gary Kramlich <grim@reaperworld.com> [Fri, 10 Feb 2023 00:59:09 -0600] rev 42052
- Add status-messages to PidginContactList
Testing Done:
Connected the demo protocol plugin and verified everything looked correct.
Bugs closed: PIDGIN-17754
Reviewed at https://reviews.imfreedom.org/r/2231/
- Fri, 10 Feb 2023 00:52:05 -0600
- by Gary Kramlich <grim@reaperworld.com> [Fri, 10 Feb 2023 00:52:05 -0600] rev 42051
- Add read-only properties for primitive and message to PurplePresence
These properties will allow us to add them to the PidginContactList without
changing the status backend.
Testing Done:
Ran the unit tests.
Bugs closed: PIDGIN-17753
Reviewed at https://reviews.imfreedom.org/r/2230/
- Thu, 09 Feb 2023 22:51:59 -0600
- by Gary Kramlich <grim@reaperworld.com> [Thu, 09 Feb 2023 22:51:59 -0600] rev 42050
- Make the DisplayWindow use a GtkListView
The traditional pattern of using a TreeView and Notebook/stack has been
removed. This now use a ListView with a model that contains the child widgets,
and an AdwBin where we swap the children in and out.
I didn't implement everything, as now that this window is a bit more mixed
content, things aren't as clear cut. I left some TODO's in the code describing
these scenarios.
Testing Done:
Tested opening and closing chats in the ui. Verified the keybinds work for navigating everything thing.
Bugs closed: PIDGIN-17752
Reviewed at https://reviews.imfreedom.org/r/2227/
- Wed, 08 Feb 2023 08:59:47 -0600
- by Gary Kramlich <grim@reaperworld.com> [Wed, 08 Feb 2023 08:59:47 -0600] rev 42049
- Export Account::error
I can't think of a good reason why we shouldn't expose the error property on
Accounts. But I would like to be able to set the error from the UI when there
is an error in the settings for example.
Testing Done:
Built the docs, ran the tests, used the prune connection action in the demo protocol plugin and verified everything was still working.
Reviewed at https://reviews.imfreedom.org/r/2216/
- Wed, 08 Feb 2023 08:56:07 -0600
- by Gary Kramlich <grim@reaperworld.com> [Wed, 08 Feb 2023 08:56:07 -0600] rev 42048
- Add a PurpleAccount parameter to the PurpleMessage constructors
This is the first step of making PurpleMessage use PurpleContactInfo's instead
of bare strings for authors and recipients.
Testing Done:
Connected and XMPP account and sent and received some messages in a MUC.
Bugs closed: PIDGIN-17724
Reviewed at https://reviews.imfreedom.org/r/2203/
- Wed, 08 Feb 2023 08:54:51 -0600
- by Gary Kramlich <grim@reaperworld.com> [Wed, 08 Feb 2023 08:54:51 -0600] rev 42047
- Remove the account lookup on account new
This is used to stop people from creating duplicate accounts. But this is bad because it hides the fact that they user recreated an existing account and will throw out new options in the UI and stuff like that.
This just disables the check for now, and I have a few more review requests I'm putting together to make this a better user experience.
Testing Done:
Ran the unit tests and created a duplicate account.
Reviewed at https://reviews.imfreedom.org/r/2214/
- Wed, 08 Feb 2023 08:24:28 -0600
- by Gary Kramlich <grim@reaperworld.com> [Wed, 08 Feb 2023 08:24:28 -0600] rev 42046
- IRCv3: Make sure we can compile against old versions of Gsasl
Testing Done:
Compiled against fedora 36 and 37. Also compiled on debian unstable and verified that SCRAM-SHA-256 was still working.
Reviewed at https://reviews.imfreedom.org/r/2229/
- Wed, 08 Feb 2023 06:18:52 -0600
- by Gary Kramlich <grim@reaperworld.com> [Wed, 08 Feb 2023 06:18:52 -0600] rev 42045
- IRCv3: Get SCRAM-SHA-256 working
This took a bit of trouble shooting, but gsasl does all the work which is very
nice. I cleaned up some logic around the server_in buffer as well, and we may
need to lock down the logic a bit in purple_ircv3_sasl_authenticate a bit, but
everything seems fine for now.
Testing Done:
Use the `SASL mechanisms` account option to force `PLAIN` and `SCRAM-SHA-256` on my local ergo instance and verified via `ngrep` that only those mechs were used.
I also deleted the values from the `SASL mechanisms` account option and verified it fell back to `PLAIN` that the server advertises. ergo doesn't advertise `SCRAM-SHA-256` for some reason, which is why this needed to depend on /r/2222.
Bugs closed: PIDGIN-17744
Reviewed at https://reviews.imfreedom.org/r/2223/
- Wed, 08 Feb 2023 06:17:57 -0600
- by Gary Kramlich <grim@reaperworld.com> [Wed, 08 Feb 2023 06:17:57 -0600] rev 42044
- IRCv3: Add an account option to specify the SASL mechanisms
This allows the user to only try the SASL mechanism they want to use instead of
potentially trying a few that won't work based on what the server advertised.
This also allows us to use SASL mechanisms that the server supports but doesn't
advertise for some reason.
Testing Done:
Set the field to `SCRAM-SHA-256` and connected to my local ergo. I verified that ONLY `SCRAM-SHA-256` was attempted (and failed see [PIDGIN-17744](https://issues.imfreedom.org/issue/PIDGIN-17744).
I deleted the value from the entry as well as from accounts.xml and verified that the server advertised values were what were used.
Bugs closed: PIDGIN-17740
Reviewed at https://reviews.imfreedom.org/r/2222/
