changelog
- Wed, 17 Sep 2008 19:24:54 +0000
- by Marcus Lundblad <malu@pidgin.im> [Wed, 17 Sep 2008 19:24:54 +0000] rev 24326
- propagate from branch 'im.pidgin.pidgin' (head 9b63613e82ab34b4b7315c801c636c365f2836c5)
to branch 'im.pidgin.xmpp.custom_smiley' (head d0de133e681c7833a40e1cb5b96256671fa99d86)
- Tue, 16 Sep 2008 23:37:36 +0000
- by Mark Doliner <markdoliner@pidgin.im> [Tue, 16 Sep 2008 23:37:36 +0000] rev 24325
- Fix DNS resolution. I think I broke this this morning in my revision
b2b1a42a78168eb8f19ba3398c0058b6a9cac4c5. I changed us to not
free the child DNS resolvers, but also to not re-use them. So it would
do 4 dns requests then just sit around waiting forever. Now resolvers
are added to the list of idle resolvers after they're done resolving.
- Tue, 16 Sep 2008 23:35:45 +0000
- by Mark Doliner <markdoliner@pidgin.im> [Tue, 16 Sep 2008 23:35:45 +0000] rev 24324
- There was a little weirdness with the code that called the UI function
for resolving DNS queries. I don't think this affects anyone I know
(not Pidgin, Finich, Adium or Meebo). It would affect someone running
on Unix/Linux and using their own DNS resolution UI op.
And even then the functionality should basically remain the same...
The code is hopefully more clean this way in the event where
ops->resolve_hosts is defined, but returns FALSE for some odd reason.
- Tue, 16 Sep 2008 23:32:15 +0000
- by Mark Doliner <markdoliner@pidgin.im> [Tue, 16 Sep 2008 23:32:15 +0000] rev 24323
- Simplify two bits of code a little
- Tue, 16 Sep 2008 23:30:47 +0000
- by Mark Doliner <markdoliner@pidgin.im> [Tue, 16 Sep 2008 23:30:47 +0000] rev 24322
- Change a string to be more user friendly (people shouldn't have any idea
what EOF means)
- Tue, 16 Sep 2008 23:29:22 +0000
- by Mark Doliner <markdoliner@pidgin.im> [Tue, 16 Sep 2008 23:29:22 +0000] rev 24321
- Improve a few comments
- Wed, 17 Sep 2008 19:09:43 +0000
- by Marcus Lundblad <malu@pidgin.im> [Wed, 17 Sep 2008 19:09:43 +0000] rev 24320
- merge of '538a72dda9c11907fd17a7c7a59b07bdd0edee63'
and '051021d40b222ded31fb22e7b845a17549f2672f'
- Tue, 16 Sep 2008 20:01:24 +0000
- by Marcus Lundblad <malu@pidgin.im> [Tue, 16 Sep 2008 20:01:24 +0000] rev 24319
- propagate from branch 'im.pidgin.pidgin' (head b2b1a42a78168eb8f19ba3398c0058b6a9cac4c5)
to branch 'im.pidgin.xmpp.custom_smiley' (head 8262725f1b86ae44380fc91110ad6ac6ab0763af)
- Tue, 16 Sep 2008 17:56:01 +0000
- by Mark Doliner <markdoliner@pidgin.im> [Tue, 16 Sep 2008 17:56:01 +0000] rev 24318
- Revert my revision 3777b91f70ab86e67c1e039d08fb6d87e06f20d6, which
removed the select() code in child DNS processes. Stu pointed out
that this code is what allowed our child DNS processes to hang
around for 40 seconds waiting for additional requests, then die a
natural death.
But that wasn't happening even WITH the select code because the parent
was killing the DNS children when it was done with them. So I
made another change to set the resolver to NULL so that it isn't
killed by purple_dnsquery_destroy().
I'm assuming that we still want our DNS lookup children to hang around
for a little while after they're done. I reduced the timeout from 40
seconds to 20 seconds.
An arguably better way to do this is to go back to having the child
block on read() instead of calling select(), then have the parent
set a timer that kills the child after a certain about of time. But
I don't see an advantage to doing it either way, and this is simpler.
- Tue, 16 Sep 2008 17:30:23 +0000
- by Mark Doliner <markdoliner@pidgin.im> [Tue, 16 Sep 2008 17:30:23 +0000] rev 24317
- Don't use g_queue_get_length because it requires glib 2.4
