Mercurial > pidgin3 / changelog

Remove the "existing window" option for where to open URLs.

• Fri, 06 Dec 2013 01:06:45 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 01:06:45 -0800] rev 35105
• Remove the "existing window" option for where to open URLs.
  
  This was kind of a dumb option. I mean, who would want that?
  We didn't support it in Chrome. We attempted to support it in
  Firefox, Netscape and Opera.
  
  It actually caused my Pidgin to hang when I tested it with Firefox.
  I'm sure it's fixable, but who cares? Here's the stacktrace, for the
  curious:
  #0 0x00007f5c461a8fbd in poll () at ../sysdeps/unix/syscall-template.S:81
  #1 0x00007f5c470be1dc in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  #2 0x00007f5c470be6ba in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  #3 0x00007f5c470ffe41 in g_spawn_sync () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  #4 0x00007f5c471002b8 in g_spawn_command_line_sync () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
  #5 0x00000000004ae804 in uri_command (command=0x203e760 "firefox -a firefox -remote openURL('http://www.yahoo.com/')",
  sync=1) at gtknotify.c:1270

Use more appropriate sized variables. Should be functionally

• Fri, 06 Dec 2013 00:43:06 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 00:43:06 -0800] rev 35104
• Use more appropriate sized variables. Should be functionally
  equivalent and performance should be basically the same. Mostly
  I think the new code is more readable.

Slightly cleaner .hgignore syntax?

• Fri, 06 Dec 2013 00:37:26 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 00:37:26 -0800] rev 35103
• Slightly cleaner .hgignore syntax?

Rename a camel case var to not be camel case.

• Fri, 06 Dec 2013 00:32:30 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 00:32:30 -0800] rev 35102
• Rename a camel case var to not be camel case.

Fix header guard and file comment.

• Fri, 06 Dec 2013 00:30:46 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 00:30:46 -0800] rev 35101
• Fix header guard and file comment.

Remove unneeded #include.

• Fri, 06 Dec 2013 00:28:49 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 00:28:49 -0800] rev 35100
• Remove unneeded #include.

Fix summary description of these files.

• Fri, 06 Dec 2013 00:26:45 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 00:26:45 -0800] rev 35099
• Fix summary description of these files.
  
  The old value was copy/pasted from another file.

No need to explicitly compare against TRUE (or FALSE).

• Fri, 06 Dec 2013 00:18:24 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 00:18:24 -0800] rev 35098
• No need to explicitly compare against TRUE (or FALSE).
  
  I know we do this a lot of other places in our code. I mostly wanted
  to change this one so I can say that I prefer not comparing against
  TRUE or FALSE explicitly :-)
  
  In c I think it's fine and a little more readable to keep it simple and
  do something like "if (blah)"

Minor comment fiddling.

• Fri, 06 Dec 2013 00:10:21 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 00:10:21 -0800] rev 35097
• Minor comment fiddling.
  
  These "TODO" comments are really intended for us, where as the
  /** doc style */ comments are intended for 3rd party devs. So
  move the TODOs into a separate comment.

More descriptive error message.

• Fri, 06 Dec 2013 00:04:30 -0800
• by Mark Doliner <mark@kingant.net> [Fri, 06 Dec 2013 00:04:30 -0800] rev 35096
• More descriptive error message.