diff -r eca262aa23ff -r 1f729ff8cab4 pidgin/gtkconv.c --- a/pidgin/gtkconv.c Wed May 30 22:05:28 2012 +0000 +++ b/pidgin/gtkconv.c Sat Jun 02 02:39:29 2012 +0000 @@ -1500,13 +1500,6 @@ } static void -menu_timestamps_cb(GtkAction *action, gpointer data) -{ - purple_prefs_set_bool(PIDGIN_PREFS_ROOT "/conversations/show_timestamps", - gtk_toggle_action_get_active(GTK_TOGGLE_ACTION(action))); -} - -static void chat_do_im(PidginConversation *gtkconv, const char *who) { PurpleConversation *conv = gtkconv->active_conv; @@ -3160,7 +3153,6 @@ { "EnableLogging", NULL, N_("Enable _Logging"), NULL, NULL, G_CALLBACK(menu_logging_cb), FALSE }, { "EnableSounds", NULL, N_("Enable _Sounds"), NULL, NULL, G_CALLBACK(menu_sounds_cb), FALSE }, { "ShowFormattingToolbars", NULL, N_("Show Formatting _Toolbars"), NULL, NULL, G_CALLBACK(menu_toolbar_cb), FALSE }, - { "ShowTimestamps", NULL, N_("Show Ti_mestamps"), NULL, NULL, G_CALLBACK(menu_timestamps_cb), FALSE }, }; static const char *conversation_menu = @@ -3205,7 +3197,6 @@ "" "" "" - "" "" "" ""; @@ -3694,9 +3685,6 @@ win->menu.show_formatting_toolbar = gtk_ui_manager_get_action(win->menu.ui, "/Conversation/OptionsMenu/ShowFormattingToolbars"); - win->menu.show_timestamps = - gtk_ui_manager_get_action(win->menu.ui, - "/Conversation/OptionsMenu/ShowTimestamps"); win->menu.tray = pidgin_menu_tray_new(); gtk_menu_shell_append(GTK_MENU_SHELL(win->menu.menubar), @@ -6671,10 +6659,13 @@ static gboolean get_iter_from_chatbuddy(PurpleConvChatBuddy *cb, GtkTreeIter *iter) { - GtkTreeRowReference *ref = purple_conv_chat_cb_get_ui_data(cb); + GtkTreeRowReference *ref; GtkTreePath *path; GtkTreeModel *model; + g_return_val_if_fail(cb != NULL, FALSE); + + ref = purple_conv_chat_cb_get_ui_data(cb); if (!ref) return FALSE; @@ -6854,6 +6845,9 @@ return; cbuddy = purple_conv_chat_cb_find(chat, user); + if (!cbuddy) + return; + if (get_iter_from_chatbuddy(cbuddy, &iter)) { GtkTreeRowReference *ref = purple_conv_chat_cb_get_ui_data(cbuddy); gtk_list_store_remove(GTK_LIST_STORE(model), &iter); @@ -7878,37 +7872,6 @@ } static void -show_timestamps_pref_cb(const char *name, PurplePrefType type, - gconstpointer value, gpointer data) -{ - GList *l; - PurpleConversation *conv; - PidginConversation *gtkconv; - PidginWindow *win; - - for (l = purple_get_conversations(); l != NULL; l = l->next) - { - conv = (PurpleConversation *)l->data; - - if (!PIDGIN_IS_PIDGIN_CONVERSATION(conv)) - continue; - - gtkconv = PIDGIN_CONVERSATION(conv); - win = gtkconv->win; - - gtk_toggle_action_set_active( - GTK_TOGGLE_ACTION(win->menu.show_timestamps), - (gboolean)GPOINTER_TO_INT(value)); - -/* TODO WEBKIT: Use WebKit version of this. */ -#if 0 - gtk_imhtml_show_comments(GTK_IMHTML(gtkconv->imhtml), - (gboolean)GPOINTER_TO_INT(value)); -#endif /* if 0 */ - } -} - -static void show_formatting_toolbar_pref_cb(const char *name, PurplePrefType type, gconstpointer value, gpointer data) { @@ -8448,6 +8411,12 @@ return TRUE; } +PurpleTheme * +pidgin_conversations_get_default_theme(void) +{ + return default_conv_theme; +} + void * pidgin_conversations_get_handle(void) { @@ -8478,7 +8447,6 @@ purple_prefs_add_int(PIDGIN_PREFS_ROOT "/conversations/custom_smileys_size", 96); purple_prefs_add_int(PIDGIN_PREFS_ROOT "/conversations/minimum_entry_lines", 2); - purple_prefs_add_bool(PIDGIN_PREFS_ROOT "/conversations/show_timestamps", TRUE); purple_prefs_add_bool(PIDGIN_PREFS_ROOT "/conversations/show_formatting_toolbar", TRUE); purple_prefs_add_string(PIDGIN_PREFS_ROOT "/conversations/placement", "last"); @@ -8527,8 +8495,6 @@ /* Connect callbacks. */ purple_prefs_connect_callback(handle, PIDGIN_PREFS_ROOT "/conversations/close_on_tabs", close_on_tabs_pref_cb, NULL); - purple_prefs_connect_callback(handle, PIDGIN_PREFS_ROOT "/conversations/show_timestamps", - show_timestamps_pref_cb, NULL); purple_prefs_connect_callback(handle, PIDGIN_PREFS_ROOT "/conversations/show_formatting_toolbar", show_formatting_toolbar_pref_cb, NULL); purple_prefs_connect_callback(handle, PIDGIN_PREFS_ROOT "/conversations/spellcheck", @@ -9747,9 +9713,6 @@ gtk_toggle_action_set_active(GTK_TOGGLE_ACTION(win->menu.show_formatting_toolbar), purple_prefs_get_bool(PIDGIN_PREFS_ROOT "/conversations/show_formatting_toolbar")); - gtk_toggle_action_set_active(GTK_TOGGLE_ACTION(win->menu.show_timestamps), - purple_prefs_get_bool(PIDGIN_PREFS_ROOT "/conversations/show_timestamps")); - /* * We pause icons when they are not visible. If this icon should * be animated then start it back up again.