# HG changeset patch # User Sadrul Habib Chowdhury # Date 1255288844 0 # Node ID 107811b9dda730372dc0ae37aea05b664a77903e # Parent 57fbfb8905c23a8ebdf4753ef1160546268c2ef3 Swap two lines to fix a crash. msn_servconn_disconnect can destroy servconn, which makes it crash on the next line. So reset the idle-handler before going into that function. diff -r 57fbfb8905c2 -r 107811b9dda7 libpurple/protocols/msn/servconn.c --- a/libpurple/protocols/msn/servconn.c Sat Oct 10 19:47:30 2009 +0000 +++ b/libpurple/protocols/msn/servconn.c Sun Oct 11 19:20:44 2009 +0000 @@ -299,8 +299,8 @@ static gboolean servconn_idle_timeout_cb(MsnServConn *servconn) { + servconn->timeout_handle = 0; msn_servconn_disconnect(servconn); - servconn->timeout_handle = 0; /* XXX: servconn may not be valid anymore */ return FALSE; }