# HG changeset patch
# User Gary Kramlich <grim@reaperworld.com>
# Date 1742880373 18000
# Node ID 1400ae254c2401b57cf8ff527ae6a9980024d1f8
# Parent  aaf1706aa25b4239e74fc198e96cc30e028604b7
IRCv3: use Purple.ConversationMembers.extend when joining channels

Testing Done:
Haven't yet. I'm working remotely on my workstation and can't easily run pidgin on it from here.

Reviewed at https://reviews.imfreedom.org/r/3924/

diff -r aaf1706aa25b -r 1400ae254c24 protocols/ircv3/purpleircv3messagehandlers.c
--- a/protocols/ircv3/purpleircv3messagehandlers.c	Tue Mar 25 00:21:37 2025 -0500
+++ b/protocols/ircv3/purpleircv3messagehandlers.c	Tue Mar 25 00:26:13 2025 -0500
@@ -344,12 +344,14 @@
 		PurpleAccount *account = NULL;
 		PurpleConnection *purple_connection = NULL;
 		PurpleContactManager *manager = purple_contact_manager_get_default();
-		PurpleConversationMembers *members = NULL;
+		PurpleConversationMembers *existing_members = NULL;
+		PurpleConversationMembers *new_members = NULL;
 
 		purple_connection = PURPLE_CONNECTION(connection);
 		account = purple_connection_get_account(purple_connection);
 
-		members = purple_conversation_get_members(conversation);
+		existing_members = purple_conversation_get_members(conversation);
+		new_members = purple_conversation_members_new();
 
 		for(guint i = 0; i < g_strv_length(nicks); i++) {
 			PurpleContact *contact = NULL;
@@ -368,7 +370,7 @@
 				purple_contact_manager_add(manager, contact);
 			}
 
-			member = purple_conversation_members_add_member(members,
+			member = purple_conversation_members_add_member(new_members,
 			                                                PURPLE_CONTACT_INFO(contact),
 			                                                FALSE, NULL);
 
@@ -376,6 +378,8 @@
 
 			g_free(stripped);
 		}
+
+		purple_conversation_members_extend(existing_members, new_members);
 	}
 
 	g_strfreev(nicks);