# HG changeset patch
# User Daniel Atallah <datallah@pidgin.im>
# Date 1092878038 0
# Node ID 18190cb3c009a1c9ea3f720c9b9720832ab1f4b3
# Parent  e3a3555b0621cce9fe8d3f16b3b92eaf14facba4
[gaim-migrate @ 10644]
A patch from Daniel Atallah that should fix sf bug 1008489:
"Windows Messenger BOT Crashes Gaim"

Someone MSN-savvy should check this to make sure it's a valid fix.

committer: Mark Doliner <markdoliner@pidgin.im>

diff -r e3a3555b0621 -r 18190cb3c009 src/protocols/msn/object.c
--- a/src/protocols/msn/object.c	Thu Aug 19 01:06:34 2004 +0000
+++ b/src/protocols/msn/object.c	Thu Aug 19 01:13:58 2004 +0000
@@ -76,6 +76,14 @@
 	GET_STRING_TAG(sha1d,    "SHA1D");
 	GET_STRING_TAG(sha1c,    "SHA1C");
 
+	/* If we are missing any of the required elements then discard the object */
+	if (obj->creator == NULL || obj->size == 0 || obj->type == 0
+			|| obj->location == NULL || obj->friendly == NULL
+			|| obj->sha1d == NULL || obj->sha1c == NULL) {
+		msn_object_destroy(obj);
+		obj = NULL;
+	}
+
 	return obj;
 }
 
diff -r e3a3555b0621 -r 18190cb3c009 src/protocols/msn/user.c
--- a/src/protocols/msn/user.c	Thu Aug 19 01:06:34 2004 +0000
+++ b/src/protocols/msn/user.c	Thu Aug 19 01:13:58 2004 +0000
@@ -285,7 +285,7 @@
 
 	user->msnobj = obj;
 
-	if (user->list_op & MSN_LIST_FL_OP)
+	if ((obj != NULL) && (user->list_op & MSN_LIST_FL_OP))
 	{
 		/* TODO: I think we need better buddy icon core functions */
 		GaimAccount *account;