# HG changeset patch # User Ankit Vani # Date 1372015645 -19800 # Node ID 2571aa9077eb9dbe7ee9bf6c78cef52b10855aea # Parent 9cdc9e6eecce12034f008be2e173c19dd3ecb0a9 Removed false alarms of memory leak diff -r 9cdc9e6eecce -r 2571aa9077eb libpurple/protocols/msn/msg.c --- a/libpurple/protocols/msn/msg.c Mon Jun 24 00:51:49 2013 +0530 +++ b/libpurple/protocols/msn/msg.c Mon Jun 24 00:57:25 2013 +0530 @@ -997,7 +997,6 @@ * the conversation doesn't exist then we cannot associate the new * smiley with its GtkIMHtml widget. */ if (!conv) { - /* TODO memory leak - dispose this conv */ conv = PURPLE_CONVERSATION(purple_im_conversation_new(session->account, who)); } diff -r 9cdc9e6eecce -r 2571aa9077eb libpurple/protocols/msn/switchboard.c --- a/libpurple/protocols/msn/switchboard.c Mon Jun 24 00:51:49 2013 +0530 +++ b/libpurple/protocols/msn/switchboard.c Mon Jun 24 00:57:25 2013 +0530 @@ -302,7 +302,7 @@ { GList *l; -#if 0 /* TODO if conv exists, it gets leaked? */ +#if 0 /* this is bad - it causes msn_switchboard_close to be called on the * switchboard we're in the middle of using :( */ if (swboard->conv != NULL)