Stop truncating ICQ passwords to 8 characters like old ICQ clients did release-2.x.y

Thu, 16 Jun 2016 02:40:40 -0300

author
dx <dx@dxzone.com.ar>
date
Thu, 16 Jun 2016 02:40:40 -0300
branch
release-2.x.y
changeset 37690
158186c0c751
parent 37687
e61fe608aa81
child 37694
c93fe5352c23

Stop truncating ICQ passwords to 8 characters like old ICQ clients did

Fixes #16692

I know we've said that we should fix this "the right way" to ensure that
hypothetical users who rely on password truncation don't get login errors.

But no one is writing that patch, and the real users who want passwords longer
than 8 chars are more important.

If someone actually relies on password truncation, they can easily press
backspace a few times.

ChangeLog file | annotate | diff | comparison | revisions
libpurple/protocols/oscar/oscar.h file | annotate | diff | comparison | revisions
--- a/ChangeLog	Wed Jun 15 21:59:51 2016 -0500
+++ b/ChangeLog	Thu Jun 16 02:40:40 2016 -0300
@@ -13,6 +13,11 @@
 	Bonjour
 	* Fixed building on Mac OSX (Patrick Cloke) (#16883)
 
+	ICQ:
+	* Stop truncating passwords to 8 characters like old ICQ clients did.
+	(#16692). If you actually needed this, truncate your password
+	manually by pressing backspace a few times.
+
 version 2.10.12 (12/31/15):
 	General:
 	* purple-url-handler now works with Python 3.x (Daniƫl van Eeden)
--- a/libpurple/protocols/oscar/oscar.h	Wed Jun 15 21:59:51 2016 -0500
+++ b/libpurple/protocols/oscar/oscar.h	Thu Jun 16 02:40:40 2016 -0300
@@ -110,7 +110,7 @@
 /**
  * Maximum length for the password of an ICQ account
  */
-#define MAXICQPASSLEN 8
+#define MAXICQPASSLEN 16
 
 #define AIM_MD5_STRING "AOL Instant Messenger (SM)"
 

mercurial