Some minor clean up in Pidgin.Conversation

Thu, 20 Mar 2025 23:01:02 -0500

author
Gary Kramlich <grim@reaperworld.com>
date
Thu, 20 Mar 2025 23:01:02 -0500
changeset 43201
1889c68bc5a0
parent 43200
163d7b5a8364
child 43202
1c2e548285f3

Some minor clean up in Pidgin.Conversation

I was trying to get the member list sorting working, but theres some more
underlying issues.

Testing Done:
Verified nothing broke

Bugs closed: PIDGIN-18045

Reviewed at https://reviews.imfreedom.org/r/3918/

pidgin/pidginconversation.c file | annotate | diff | comparison | revisions
--- a/pidgin/pidginconversation.c	Thu Mar 20 22:59:13 2025 -0500
+++ b/pidgin/pidginconversation.c	Thu Mar 20 23:01:02 2025 -0500
@@ -380,16 +380,11 @@
 {
 	PurpleConversationMember *member_a = NULL;
 	PurpleConversationMember *member_b = NULL;
-	PurpleContactInfo *info_a = NULL;
-	PurpleContactInfo *info_b = NULL;
 
 	member_a = PURPLE_CONVERSATION_MEMBER((gpointer)a);
 	member_b = PURPLE_CONVERSATION_MEMBER((gpointer)b);
 
-	info_a = purple_conversation_member_get_contact_info(member_a);
-	info_b = purple_conversation_member_get_contact_info(member_b);
-
-	return purple_contact_info_compare(info_a, info_b);
+	return purple_conversation_member_compare(member_a, member_b);
 }
 
 static gboolean
@@ -517,9 +512,9 @@
 
 static void
 pidgin_conversation_init(PidginConversation *conversation) {
+	GMenuModel *menu = NULL;
 	SpellingChecker *checker = NULL;
 	SpellingTextBufferAdapter *adapter = NULL;
-	GMenuModel *menu = NULL;
 
 	gtk_widget_init_template(GTK_WIDGET(conversation));
 

mercurial