Mon, 24 Jun 2013 00:57:25 +0530
Removed false alarms of memory leak
| libpurple/protocols/msn/msg.c | file | annotate | diff | comparison | revisions | |
| libpurple/protocols/msn/switchboard.c | file | annotate | diff | comparison | revisions |
--- a/libpurple/protocols/msn/msg.c Mon Jun 24 00:51:49 2013 +0530 +++ b/libpurple/protocols/msn/msg.c Mon Jun 24 00:57:25 2013 +0530 @@ -997,7 +997,6 @@ * the conversation doesn't exist then we cannot associate the new * smiley with its GtkIMHtml widget. */ if (!conv) { - /* TODO memory leak - dispose this conv */ conv = PURPLE_CONVERSATION(purple_im_conversation_new(session->account, who)); }
--- a/libpurple/protocols/msn/switchboard.c Mon Jun 24 00:51:49 2013 +0530 +++ b/libpurple/protocols/msn/switchboard.c Mon Jun 24 00:57:25 2013 +0530 @@ -302,7 +302,7 @@ { GList *l; -#if 0 /* TODO if conv exists, it gets leaked? */ +#if 0 /* this is bad - it causes msn_switchboard_close to be called on the * switchboard we're in the middle of using :( */ if (swboard->conv != NULL)