jabber: Fix some review comments.

Sun, 03 Nov 2019 16:35:44 -0500

author
Elliott Sales de Andrade <qulogic@pidgin.im>
date
Sun, 03 Nov 2019 16:35:44 -0500
changeset 40111
3acd6bb854c4
parent 40110
bc2b94f2595a
child 40112
52c9656e40ed

jabber: Fix some review comments.

* Remove a static buffer.
* Remove a redundant condition check.

libpurple/protocols/jabber/jabber.c file | annotate | diff | comparison | revisions
--- a/libpurple/protocols/jabber/jabber.c	Sun Nov 03 16:26:09 2019 -0500
+++ b/libpurple/protocols/jabber/jabber.c	Sun Nov 03 16:35:44 2019 -0500
@@ -601,7 +601,7 @@
 	PurpleConnection *gc = data;
 	JabberStream *js = purple_connection_get_protocol_data(gc);
 	gssize len;
-	static char buf[4096];
+	gchar buf[4096];
 	GError *error = NULL;
 
 	PURPLE_ASSERT_CONNECTION_IS_VALID(gc);
@@ -1598,9 +1598,7 @@
 		js->bosh = NULL;
 	} else if (js->output != NULL) {
 		jabber_send_raw(js, "</stream:stream>", -1);
-	}
-
-	if (js->output != NULL) {
+
 		if(js->inpa) {
 			g_source_remove(js->inpa);
 			js->inpa = 0;

mercurial