Mercurial > pidgin3 / changeset

• changeset
• raw

changeset

IRCv3: Remove an old work around that's no longer necessary

Mon, 13 Jan 2025 00:36:11 -0600

author

Gary Kramlich <grim@reaperworld.com>

date

Mon, 13 Jan 2025 00:36:11 -0600

changeset 43131

42a2947d36c6

parent 43130

ad73c9be8cb1

child 43132

b8a7d50eb1ae

IRCv3: Remove an old work around that's no longer necessary

I'm not sure what dialog this was referring to, but regardless we don't have
a dialog to create conversations right now so this is unnecessary.

Testing Done:
Called in the turtles.

Bugs closed: PIDGIN-18001

Reviewed at https://reviews.imfreedom.org/r/3747/

--- a/protocols/ircv3/purpleircv3protocolconversation.c	Thu Jan 09 20:59:45 2025 -0600
+++ b/protocols/ircv3/purpleircv3protocolconversation.c	Mon Jan 13 00:36:11 2025 -0600
@@ -65,13 +65,6 @@
 	}
 
 	id = purple_conversation_get_id(conversation);
-	/* TODO: the new message dialog sets the name but not the id and we want to
-	 * use the id only, so for now if id is NULL we grab the name.
-	 */
-	if(purple_strempty(id)) {
-		id = purple_conversation_get_name(conversation);
-	}
-
 	contents = purple_message_get_contents(message);
 
 	ibis_message = ibis_message_new(IBIS_MSG_PRIVMSG);