Wed, 10 Mar 2010 01:25:24 +0000
jabber: Connected again; checked section 5.4.5 of the bis.
"The minor version number MUST be ignored by an entity with a smaller
minor version number"
I really need to keep a copy of all the XMPP specs on my laptop.
| libpurple/protocols/jabber/parser.c | file | annotate | diff | comparison | revisions |
--- a/libpurple/protocols/jabber/parser.c Tue Mar 09 23:13:42 2010 +0000 +++ b/libpurple/protocols/jabber/parser.c Wed Mar 10 01:25:24 2010 +0000 @@ -56,10 +56,8 @@ js->protocol_version.major = atoi(attrib); js->protocol_version.minor = dot ? atoi(dot + 1) : 0; - /* TODO: Check this against the spec; I'm not sure if the check - * against minor is accurate. - */ - if (js->protocol_version.major > 1 || (js->protocol_version == 1 && js->protocol_version.minor > 0)) + if (js->protocol_version.major > 1) + /* TODO: Send <unsupported-version/> error */ purple_connection_error_reason(js->gc, PURPLE_CONNECTION_ERROR_AUTHENTICATION_IMPOSSIBLE, _("XMPP Version Mismatch"));