[gaim-migrate @ 15245]

Mon, 16 Jan 2006 10:19:31 +0000

author
Etan Reisner <deryni@pidgin.im>
date
Mon, 16 Jan 2006 10:19:31 +0000
changeset 12892
aa322da897d6
parent 12891
6e089bd3cb0e
child 12893
cc122cfc24dc

[gaim-migrate @ 15245]
These functions return a list of strings in C, in perl they were retuning a
blessed object that didn't seem to have any use, so I made them return strings
instead so they work "normally". I think this an improvement.

plugins/perl/common/Cmds.xs file | annotate | diff | comparison | revisions
plugins/perl/common/Conversation.xs file | annotate | diff | comparison | revisions
plugins/perl/common/Request.xs file | annotate | diff | comparison | revisions
--- a/plugins/perl/common/Cmds.xs	Mon Jan 16 10:17:17 2006 +0000
+++ b/plugins/perl/common/Cmds.xs	Mon Jan 16 10:19:31 2006 +0000
@@ -12,7 +12,7 @@
 	GList *l;
 PPCODE:
 	for (l = gaim_cmd_help(conv, command); l != NULL; l = l->next) {
-		XPUSHs(sv_2mortal(gaim_perl_bless_object(l->data, "Gaim::ListEntry")));
+		XPUSHs(sv_2mortal(newSVpv(l->data, 0)));
 	}
 
 void
@@ -22,7 +22,7 @@
 	GList *l;
 PPCODE:
 	for (l = gaim_cmd_list(conv); l != NULL; l = l->next) {
-		XPUSHs(sv_2mortal(gaim_perl_bless_object(l->data, "Gaim::ListEntry")));
+		XPUSHs(sv_2mortal(newSVpv(l->data, 0)));
 	}
 
 Gaim::Cmd::Id
--- a/plugins/perl/common/Conversation.xs	Mon Jan 16 10:17:17 2006 +0000
+++ b/plugins/perl/common/Conversation.xs	Mon Jan 16 10:19:31 2006 +0000
@@ -52,7 +52,7 @@
 	GList *l;
 PPCODE:
 	for (l = gaim_conversation_get_send_history(conv); l != NULL; l = l->next) {
-		XPUSHs(sv_2mortal(gaim_perl_bless_object(l->data, "Gaim::ListEntry")));
+		XPUSHs(sv_2mortal(newSVpv(l->data, 0)));
 	}
 
 void
--- a/plugins/perl/common/Request.xs	Mon Jan 16 10:17:17 2006 +0000
+++ b/plugins/perl/common/Request.xs	Mon Jan 16 10:19:31 2006 +0000
@@ -246,7 +246,7 @@
 	GList *l;
 PPCODE:
 	for (l = gaim_request_field_choice_get_labels(field); l != NULL; l = l->next) {
-		XPUSHs(sv_2mortal(gaim_perl_bless_object(l->data, "Gaim::ListItem")));
+		XPUSHs(sv_2mortal(newSVpv(l->data, 0)));
 	}
 
 int
@@ -353,7 +353,7 @@
 	const GList *l;
 PPCODE:
 	for (l = gaim_request_field_list_get_items(field); l != NULL; l = l->next) {
-		XPUSHs(sv_2mortal(gaim_perl_bless_object(l->data, "Gaim::ListItem")));
+		XPUSHs(sv_2mortal(newSVpv(l->data, 0)));
 	}
 
 gboolean
@@ -367,7 +367,7 @@
 	const GList *l;
 PPCODE:
 	for (l = gaim_request_field_list_get_selected(field); l != NULL; l = l->next) {
-		XPUSHs(sv_2mortal(gaim_perl_bless_object(l->data, "Gaim::ListItem")));
+		XPUSHs(sv_2mortal(newSVpv(l->data, 0)));
 	}
 
 gboolean

mercurial