Remove active tracking in PidginPrefsCombo

Tue, 17 May 2022 01:58:52 -0500

author
Elliott Sales de Andrade <quantum.analyst@gmail.com>
date
Tue, 17 May 2022 01:58:52 -0500
changeset 41382
b45e9fceeae9
parent 41381
acedeb1e8804
child 41383
686ea9361312

Remove active tracking in PidginPrefsCombo

The only thing that ever reads it is setting the previous to current.

pidgin/prefs/pidginprefs.c file | annotate | diff | comparison | revisions
pidgin/prefs/pidginprefsinternal.h file | annotate | diff | comparison | revisions
--- a/pidgin/prefs/pidginprefs.c	Tue May 17 01:58:51 2022 -0500
+++ b/pidgin/prefs/pidginprefs.c	Tue May 17 01:58:52 2022 -0500
@@ -226,11 +226,6 @@
 		return;
 	}
 
-	g_object_set_data(G_OBJECT(combo_box), "previously_active",
-		g_object_get_data(G_OBJECT(combo_box), "current_active"));
-	g_object_set_data(G_OBJECT(combo_box), "current_active",
-		GINT_TO_POINTER(gtk_combo_box_get_active(combo_box)));
-
 	type = GPOINTER_TO_INT(g_object_get_data(G_OBJECT(combo_box), "type"));
 	key = g_object_get_data(G_OBJECT(combo_box), "key");
 	if (type == PURPLE_PREF_INT) {
@@ -261,7 +256,6 @@
 	GtkTreeIter iter;
 	GtkTreeIter active;
 	GtkCellRenderer *renderer;
-	gpointer current_active;
 
 	g_return_val_if_fail(menuitems != NULL, NULL);
 
@@ -333,10 +327,6 @@
 	                               NULL);
 
 	gtk_combo_box_set_active_iter(GTK_COMBO_BOX(dropdown), &active);
-	current_active = GINT_TO_POINTER(gtk_combo_box_get_active(GTK_COMBO_BOX(
-		dropdown)));
-	g_object_set_data(G_OBJECT(dropdown), "current_active", current_active);
-	g_object_set_data(G_OBJECT(dropdown), "previously_active", current_active);
 
 	g_signal_connect(dropdown, "changed", G_CALLBACK(dropdown_set), NULL);
 
@@ -420,9 +410,6 @@
 	if (!gtk_combo_box_get_active_iter(combo_box, &iter))
 		return;
 
-	combo->previously_active = combo->current_active;
-	combo->current_active = gtk_combo_box_get_active(combo_box);
-
 	if (combo->type == PURPLE_PREF_INT) {
 		gtk_tree_model_get(tree_model, &iter, PREF_DROPDOWN_VALUE,
 			&combo->value.integer, -1);
@@ -509,9 +496,6 @@
 	}
 
 	gtk_combo_box_set_active_iter(GTK_COMBO_BOX(combo->combo), &active);
-	combo->current_active = gtk_combo_box_get_active(
-			GTK_COMBO_BOX(combo->combo));
-	combo->previously_active = combo->current_active;
 
 	g_signal_connect(G_OBJECT(combo->combo), "changed",
 			G_CALLBACK(bind_dropdown_set), combo);
@@ -576,10 +560,6 @@
 
 	gtk_combo_box_set_active_iter(GTK_COMBO_BOX(combo->combo), &active);
 
-	combo->current_active = gtk_combo_box_get_active(
-			GTK_COMBO_BOX(combo->combo));
-	combo->previously_active = combo->current_active;
-
 	g_signal_connect(G_OBJECT(combo->combo), "changed",
 			G_CALLBACK(bind_dropdown_set), combo);
 }
--- a/pidgin/prefs/pidginprefsinternal.h	Tue May 17 01:58:51 2022 -0500
+++ b/pidgin/prefs/pidginprefsinternal.h	Tue May 17 01:58:52 2022 -0500
@@ -40,8 +40,6 @@
 		int integer;
 		gboolean boolean;
 	} value;
-	gint previously_active;
-	gint current_active;
 };
 
 G_BEGIN_DECLS

mercurial