Remove the doc comments as they're in the header file and use g_set_object as we're on glib 2.44 now

Thu, 09 May 2019 22:38:16 -0500

author
Gary Kramlich <grim@reaperworld.com>
date
Thu, 09 May 2019 22:38:16 -0500
changeset 39584
b8155feb19d5
parent 39583
d951e625d987
child 39585
8a19d82a81f8

Remove the doc comments as they're in the header file and use g_set_object as we're on glib 2.44 now

pidgin/pidgincontactcompletion.c file | annotate | diff | comparison | revisions
--- a/pidgin/pidgincontactcompletion.c	Thu May 09 22:37:39 2019 -0500
+++ b/pidgin/pidgincontactcompletion.c	Thu May 09 22:38:16 2019 -0500
@@ -251,15 +251,6 @@
 	return GTK_ENTRY_COMPLETION(g_object_new(PIDGIN_TYPE_CONTACT_COMPLETION, NULL));
 }
 
-/**
- * pidgin_contact_completion_get_account:
- * @completion: The #PidginContactCompletion instance.
- *
- * Gets the #PurpleAccount who's contacts we're filtering for, or %NULL if
- * there is no filtering.
- *
- * Returns: (transfer full): The #PurpleAccount.
- */
 PurpleAccount *
 pidgin_contact_completion_get_account(PidginContactCompletion *completion) {
 	g_return_val_if_fail(PIDGIN_IS_CONTACT_COMPLETION(completion), NULL);
@@ -267,28 +258,14 @@
 	return g_object_ref(completion->account);
 }
 
-/**
- * pidgin_contact_completion_set_account:
- * @completion: The #PidginContactCompletion instance.
- * @account: The #PurpleAccount to filter for.
- *
- * Sets the #PurpleAccount who's contacts should be shown or %NULL
- * to show contacts from all accounts.
- */
 void
 pidgin_contact_completion_set_account(PidginContactCompletion *completion,
                                       PurpleAccount *account)
 {
 	g_return_if_fail(PIDGIN_IS_CONTACT_COMPLETION(completion));
 
-	if(completion->account != NULL) {
-		g_clear_pointer(&completion->account, g_object_unref);
+	if(g_set_object(&completion->account, account)) {
+		g_object_notify_by_pspec(G_OBJECT(completion),
+		                         properties[PROP_ACCOUNT]);
 	}
-
-	if(PURPLE_IS_ACCOUNT(account)) {
-		completion->account = g_object_ref(account);
-	}
-
-	g_object_notify_by_pspec(G_OBJECT(completion),
-	                         properties[PROP_ACCOUNT]);
 }

mercurial