Add some safety to jabber_send_signal_cb in case someone else was listening

Wed, 25 Nov 2009 19:00:39 +0000

author
Stu Tomlinson <nosnilmot@pidgin.im>
date
Wed, 25 Nov 2009 19:00:39 +0000
changeset 28974
c781d3082146
parent 28973
be6a842df4b9
child 28975
28b4c6c5110d

Add some safety to jabber_send_signal_cb in case someone else was listening
to jabber-sending-xmlnode and caused the connection to get disconnected
before the signal got to calling jabber_send_signal_cb. Should fix
https://bugzilla.redhat.com/show_bug.cgi?id=540835

libpurple/protocols/jabber/jabber.c file | annotate | diff | comparison | revisions
--- a/libpurple/protocols/jabber/jabber.c	Wed Nov 25 16:39:29 2009 +0000
+++ b/libpurple/protocols/jabber/jabber.c	Wed Nov 25 19:00:39 2009 +0000
@@ -476,7 +476,14 @@
 	if (NULL == packet)
 		return;
 
+	if (!PURPLE_CONNECTION_IS_VALID(pc))
+		return;
+
 	js = purple_connection_get_protocol_data(pc);
+
+	if (NULL == js)
+		return;
+
 	if (js->bosh)
 		if (g_str_equal((*packet)->name, "message") ||
 				g_str_equal((*packet)->name, "iq") ||

mercurial