Mercurial > pidgin3 / annotate

pidgin/plugins/transparency/im.pidgin.Pidgin.plugin.Transparency.gschema.xml@04c0398f1046 (annotated)

pidgin/plugins/transparency/im.pidgin.Pidgin.plugin.Transparency.gschema.xml

Wed, 29 Mar 2023 23:32:07 -0500

author
Elliott Sales de Andrade <quantum.analyst@gmail.com>
date
Wed, 29 Mar 2023 23:32:07 -0500
changeset 42188
04c0398f1046
parent 41742
40130f43df93
permissions
-rw-r--r--

Fix transparency plugin for display list/pref changes

There is no longer a buddy list/conversation split, so remove the duplicate settings (half of which were not used any more), and rename them without the differentiating prefix. Also, now that there's only one thing, there's no need for a second "enabled" setting in the plugin that just duplicates the plugin's enabled setting itself, so I removed it.

Instead of adding and removing a slider when the setting changes, I instead opted to always add it, and bind its visibility to the setting instead.

We no longer need a `gtk-config-frame` now that Pidgin uses GPlugin's plugin settings, so remove that and correctly wire up the settings schema so that GPlugin automatically displays settings.

Finally, the scale UI and alpha setting had different ranges. If the setting was moved below the scale's minimum, it would clamp it but not resend that value back to the setting, so things would appear inconsistent. To rectify this, I changed the setting's range up to match the scale.

Testing Done:
* Enabled Transparency plugin, changed around the transparency level and confirmed the main window became transparent.
* Toggled the solid-on-focus setting and confirmed the window lost transparency when focused.
* Toggled the slider setting and confirmed it was added/removed from the window.
* When slider was enabled, changed the setting and confirmed the slider changed and vice versa.

Reviewed at https://reviews.imfreedom.org/r/2394/

41742
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
1 <?xml version="1.0" encoding="utf-8"?>
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
2 <schemalist>
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
3 <schema path="/pidgin/plugins/transparency/" id="im.pidgin.Pidgin.plugin.Transparency">
42188
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
4 <key name="alpha" type="i">
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
5 <default>255</default>
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
6 <range min="50" max="255"/>
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
7 <summary>Transparency level</summary>
41742
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
8 <description>
42188
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
9 The opacity applied to a window.
41742
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
10 </description>
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
11 </key>
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
12
42188
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
13 <key name="slider" type="b">
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
14 <default>false</default>
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
15 <summary>Show slider bar in windows</summary>
41742
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
16 <description>
42188
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
17 Shows a slider bar in windows with which the transparency level may
41742
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
18 be modified.
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
19 </description>
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
20 </key>
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
21
42188
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
22 <key name="solid-on-focus" type="b">
41742
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
23 <default>false</default>
42188
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
24 <summary>Remove window transparency on focus</summary>
41742
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
25 <description>
42188
04c0398f1046 Fix transparency plugin for display list/pref changes
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents: 41742
diff changeset
26 Whether to make a window opaque whenever it has focus.
41742
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
27 </description>
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
28 </key>
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
29 </schema>
40130f43df93 Convert transparency plugin to GSettings
Elliott Sales de Andrade <quantum.analyst@gmail.com>
parents:
diff changeset
30 </schemalist>

Mercurial Repository: pidgin3

mercurial