changelog
- Thu, 02 Jun 2022 21:06:26 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 02 Jun 2022 21:06:26 -0500] rev 41422
- Prepare for the 2.14.10 release
Testing Done:
Ran `codespell` and `make distcheck`
Reviewed at https://reviews.imfreedom.org/r/1489/
- Thu, 02 Jun 2022 20:17:31 -0500
- by Belgin Știrbu <belginstirbu@hotmail.com> [Thu, 02 Jun 2022 20:17:31 -0500] rev 41421
- Fix crash when cancelling an XMPP file transfer
When an XMPP account has file transfers and the
connection to the XMPP server drops, the JabberStream object
gets g_free()'d, but the PurpleXfers still have pointers to it,
so when the file transfer finishes or is canceled, it tries
to remove itself from the JabberStream object and it ends up
accessing invalid memory, causing a crash.
This patch closes all file transfers associated to
a JabberStream object, right before the object gets g_free()'d.
Testing Done:
Reliably reproduced the crash by closing internet connection while a transfer was in progress. After the patch, the crash no longer occurs because the transfers all end when the internet connection drops.
Bugs closed: PIDGIN-17189
Reviewed at https://reviews.imfreedom.org/r/1485/
- Thu, 02 Jun 2022 20:15:50 -0500
- by ivanhoe <ivanhoe@fiscari.de> [Thu, 02 Jun 2022 20:15:50 -0500] rev 41420
- fix use after free
This fixes an invalid read showing up in valgrind when opening some conversations in Pidgin and the closing Pidgin.
The code was introduced with /r/1342. It looks pretty straightforward so I hope I'm not messing with the fixes that were done in that RR.
Testing Done:
Started Pidgin in valgrind, opened some conversations and closed Pidgin again. No more invalid reads are shown.
Reviewed at https://reviews.imfreedom.org/r/1488/
- Tue, 31 May 2022 00:07:27 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 31 May 2022 00:07:27 -0500] rev 41419
- Emit the irc-sending-text signal for all irc messages.
This was accidentally broken with the priority message sending stuff when the
rate limiter was added.
Testing Done:
Connected to libera and everything seemed to be fine. Waited for the antispam timer and verified that both part and quit messages which use `irc_priority_send` worked via the `irc-more` plugin.
Bugs closed: PIDGIN-17626
Reviewed at https://reviews.imfreedom.org/r/1483/
- Mon, 30 May 2022 23:25:18 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 30 May 2022 23:25:18 -0500] rev 41418
- Convert all of the buddylist context menus to GMenu
Testing Done:
Every item every way I think...
Reviewed at https://reviews.imfreedom.org/r/1481/
- Mon, 30 May 2022 23:23:52 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 30 May 2022 23:23:52 -0500] rev 41417
- Start putting the ChangeLog together for 2.14.10.
Testing Done:
Ran codespell
Reviewed at https://reviews.imfreedom.org/r/1486/
- Mon, 30 May 2022 21:04:47 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 30 May 2022 21:04:47 -0500] rev 41416
- Remove the manager, editor, and substatus editor from gtksavedstatuses
This code previously replaced via the new PidginStatusManager and
PidginStatusEditor widgets, while substatuses were skipped as we determine their
future.
Testing Done:
Ran and opened all the status dialogs and menus and stuff.
Reviewed at https://reviews.imfreedom.org/r/1437/
- Mon, 30 May 2022 20:52:30 -0500
- by Belgin Știrbu <belginstirbu@hotmail.com> [Mon, 30 May 2022 20:52:30 -0500] rev 41415
- Fix segmentation fault on IRC server reply
When Pidgin received `:nick!user@host JOIN #channel` from an IRC
server, it worked fine, but when it received
`:nick JOIN #channel`, it crashed with a segmentation fault.
Testing Done:
Tested with a custom IRC server that only sends the nickname. Also tested on Libera Chat.
Bugs closed: PIDGIN-17375
Reviewed at https://reviews.imfreedom.org/r/1484/
- Fri, 27 May 2022 14:52:34 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 27 May 2022 14:52:34 -0500] rev 41414
- Convert plugin actions to GMenu and GAction
Also ported the idle maker plugin to the new api.
Testing Done:
Made sure all of the actions for the idle maker plugin worked.
Reviewed at https://reviews.imfreedom.org/r/1408/
- Fri, 27 May 2022 04:11:45 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 27 May 2022 04:11:45 -0500] rev 41413
- Remove some dead blist code
Testing Done:
Compiled only.
Reviewed at https://reviews.imfreedom.org/r/1482/
