changelog
- Fri, 10 Jun 2022 20:42:36 -0500
- by ivanhoe <ivanhoe@fiscari.de> [Fri, 10 Jun 2022 20:42:36 -0500] rev 41432
- fix memory leak when using purple accounts
Testing Done:
ran test_account_manager and test_notification (from /r/1502 where I first encountered that leak) in valgrind -> no more leak and no new invalid read/write
Reviewed at https://reviews.imfreedom.org/r/1503/
- Fri, 10 Jun 2022 03:37:33 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 10 Jun 2022 03:37:33 -0500] rev 41431
- Rename PidginContactList to PidginContactListWindow.
This is necessary as we want to use PidginContactList as the widget name of the
actual contact list widget.
Testing Done:
Verified that the contact list displayed properly.
Bugs closed: PIDGIN-17629
Reviewed at https://reviews.imfreedom.org/r/1498/
- Thu, 09 Jun 2022 03:12:46 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 09 Jun 2022 03:12:46 -0500] rev 41430
- Remove a few more lines I missed about the chat user list width preference.
Testing Done:
Ran in `gdb` with `G_DEBUG=fatal-warnings`, joined a chat, resized the list and moved the window around and verified that the `G_CRITICAL`'s were gone for real this time.
Reviewed at https://reviews.imfreedom.org/r/1497/
- Thu, 09 Jun 2022 03:04:16 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 09 Jun 2022 03:04:16 -0500] rev 41429
- Make PurpleAccount take ownership of the connection that was set.
This should fix the infinite loop on exit.
Testing Done:
Connected an IRC account and was unable to trigger the infinite loop.
Reviewed at https://reviews.imfreedom.org/r/1496/
- Thu, 09 Jun 2022 03:01:29 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 09 Jun 2022 03:01:29 -0500] rev 41428
- Fix purple_conversation_manager_find_chat_by_id.
purple_conversation_manager_find_chat_by_id was calling
purple_conversation_manager_find_internal with a name of NULL. However,
purple_conversation_manager_find_internal was always requring the conversation
name to matched what was passed in.
Therefore purple_conversation_manager_find_chat_by_id never actually worked.
Testing Done:
Connected an IRC account and successfully sent a message.
Reviewed at https://reviews.imfreedom.org/r/1495/
- Tue, 07 Jun 2022 00:43:47 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 07 Jun 2022 00:43:47 -0500] rev 41427
- We removed the preference for tracking the user list width but missed some code
Testing Done:
Joined and chat and verified the `g_critial` was gone.
Reviewed at https://reviews.imfreedom.org/r/1492/
- Mon, 06 Jun 2022 21:22:16 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 06 Jun 2022 21:22:16 -0500] rev 41426
- Properly set XMPP connection errors.
This fixes a regression from /r/1358/.
Testing Done:
Connected and disconnected an XMPP account. Made sure the account was connected, then quit and relaunched, saw an error about signing in from another location, but then it reconnected properly.
Reviewed at https://reviews.imfreedom.org/r/1491/
- Sat, 04 Jun 2022 04:10:44 -0500
- by Gary Kramlich <grim@reaperworld.com> [Sat, 04 Jun 2022 04:10:44 -0500] rev 41425
- Properly set XMPP connection errors.
This fixes a regression from /r/1358/.
Testing Done:
Connected and disconnected an XMPP account. Made sure the account was connected, then quit and relaunched, saw an error about signing in from another location, but then it reconnected properly.
Reviewed at https://reviews.imfreedom.org/r/1491/
- Sat, 04 Jun 2022 03:54:32 -0500
- by ivanhoe <ivanhoe@fiscari.de> [Sat, 04 Jun 2022 03:54:32 -0500] rev 41424
- fix typos in code contributions guide
Testing Done:
None
Reviewed at https://reviews.imfreedom.org/r/1493/
- Thu, 02 Jun 2022 21:27:54 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 02 Jun 2022 21:27:54 -0500] rev 41423
- Added tag v2.14.10 for changeset 594d72369304
