changelog
- Thu, 17 Aug 2023 21:41:12 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 17 Aug 2023 21:41:12 -0500] rev 42276
- Remove the posix signals from Pidgin
These weren't really doing much for us and are in the way for the crash handler
stuff that we want to do in the future.
Testing Done:
Connected an IRCv3 account without issue.
Reviewed at https://reviews.imfreedom.org/r/2566/
- Tue, 15 Aug 2023 15:49:01 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 15 Aug 2023 15:49:01 -0500] rev 42275
- Add a basic status window to the IRCv3 protocol plugin
There's a lot more to be tweaked in here, including adding an account action
to toggle visibility, but the basics work for now.
Testing Done:
Connected to libera and my local ergo and checked it out!
Bugs closed: PIDGIN-17819
Reviewed at https://reviews.imfreedom.org/r/2563/
- Tue, 15 Aug 2023 02:28:08 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 15 Aug 2023 02:28:08 -0500] rev 42274
- Add missing documentation for PurpleAccount properties
Testing Done:
built docs and ran the unit tests
Reviewed at https://reviews.imfreedom.org/r/2562/
- Tue, 15 Aug 2023 02:26:12 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 15 Aug 2023 02:26:12 -0500] rev 42273
- Add some minor unit tests to PurpleConversationManager
For some reason we didn't have any unit tests for PurpleConversationManager so
this just adds a register/unregister test to make sure the basics are working.
I kept this brief because I already found a number of issues, and I'm sure we'll find more as we add more tests.
Testing Done:
Ran the tests.
Reviewed at https://reviews.imfreedom.org/r/2561/
- Mon, 14 Aug 2023 23:18:22 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 14 Aug 2023 23:18:22 -0500] rev 42272
- Add an id property to PurpleConversation
And a lookup method it PurpleConversationManager as well.
Testing Done:
Ran the unit tests for conversations and conversation manager doesn't have any.
Reviewed at https://reviews.imfreedom.org/r/2560/
- Mon, 14 Aug 2023 22:42:40 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 14 Aug 2023 22:42:40 -0500] rev 42271
- Set the sasl login name on successful login if not set
We tried to do this previously, but it was just done when the connection was
created rather than waiting until we had successfully logged in with the user's
nick.
Testing Done:
Created an ircv3 account with the wrong user name, failed to login, and made sure that the sasl login name was not set. Then fixed the username, logged in successfully, and verified that the sasl login name was set properly.
Reviewed at https://reviews.imfreedom.org/r/2559/
- Mon, 14 Aug 2023 22:34:51 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 14 Aug 2023 22:34:51 -0500] rev 42270
- Propagate notify signals from the priority contact of a person
I also ported the person unit tests to the new status api, which also required
updating purple_presence_compare. I didn't notice any breakage there, but I
didn't look too hard.
I also update the person unit tests to use a counter for the notify signal
being called instead of a boolean.
Testing Done:
Ran the unit tests which required a fair amount refactoring and connected a demo and xmpp account without issue.
Bugs closed: PIDGIN-17755
Reviewed at https://reviews.imfreedom.org/r/2557/
- Tue, 08 Aug 2023 04:47:47 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Tue, 08 Aug 2023 04:47:47 -0500] rev 42269
- Fix some scan-build issues
* In `finch/gntaccount.c`, scan-build thinks that `dialog->account` may change
between the two places it is used; this is not the case, but easiest to
placate it by using a common variable.
* In `finch/gntblist.c`, comment out more code to limit dead stores.
* In `libpurple/mediamanager.c` and `pidgin/gtkrequest.c`, a non-NULL
initializer is used on a variable that is replaced later by the same thing,
so just initialize to NULL instead.
Testing Done:
Compiled with `ninja scan-build`.
Reviewed at https://reviews.imfreedom.org/r/2554/
- Tue, 08 Aug 2023 01:41:19 -0500
- by Gary Kramlich <grim@reaperworld.com> [Tue, 08 Aug 2023 01:41:19 -0500] rev 42268
- Add a connected property to PurpleAccount so bindings can use it
While fixing some bugs in the account editor, I ended up manually settings some
widgets sensitivity depending on an account being connected. However this
easily gets out of sync if the editor is open and an account switches online
states. With this property we will be able to bind and not fall out of sync.
Testing Done:
Compiled
Bugs closed: PIDGIN-17815
Reviewed at https://reviews.imfreedom.org/r/2542/
- Mon, 07 Aug 2023 23:23:40 -0500
- by Gary Kramlich <grim@reaperworld.com> [Mon, 07 Aug 2023 23:23:40 -0500] rev 42267
- Remove a bunch of dead code from gtkconv
I tried my best to get the keybindings working, but none of them did.
Testing Done:
Compiled and tried all sorts of keybindings in the history and input. I had a message selected in the history and was able to type in the input without any of that old code.
Reviewed at https://reviews.imfreedom.org/r/2538/
