Mercurial > pidgin3 / changelog

Remove libsoup2 code

• Tue, 21 Mar 2023 02:07:16 -0500
• by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Tue, 21 Mar 2023 02:07:16 -0500] rev 42176
• Remove libsoup2 code
  
  Soup 3 has been required since /r/2068.
  
  Testing Done:
  Compiled only.
  
  Reviewed at https://reviews.imfreedom.org/r/2375/

Use g_clear_handle_id everywhere

• Tue, 21 Mar 2023 01:59:19 -0500
• by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Tue, 21 Mar 2023 01:59:19 -0500] rev 42175
• Use g_clear_handle_id everywhere
  
  Testing Done:
  Compiled and ran tests in valgrind.
  
  Reviewed at https://reviews.imfreedom.org/r/2374/

Remove unused callback in account editor

• Tue, 21 Mar 2023 00:46:58 -0500
• by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Tue, 21 Mar 2023 00:46:58 -0500] rev 42174
• Remove unused callback in account editor
  
  It is no longer a dialog, and has no reference to a response callback in the `.ui` any more.
  
  Also, fix the added CSS class.
  
  Testing Done:
  Compiled, and opened and closed the account editor.
  
  Reviewed at https://reviews.imfreedom.org/r/2373/

Add purple_presence_primitive_to_string for easier display

• Tue, 21 Mar 2023 00:40:41 -0500
• by Gary Kramlich <grim@reaperworld.com> [Tue, 21 Mar 2023 00:40:41 -0500] rev 42173
• Add purple_presence_primitive_to_string for easier display
  
  Testing Done:
  Compiled
  
  Reviewed at https://reviews.imfreedom.org/r/2371/

Use g_clear_* helpers where useful

• Tue, 21 Mar 2023 00:39:45 -0500
• by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Tue, 21 Mar 2023 00:39:45 -0500] rev 42172
• Use g_clear_* helpers where useful
  
  That is:
  
  * when the variable is set to `NULL` right after freeing
  * when the variable is checked for non-`NULL` before freeing
  * when the variable is a global (because they should be set to `NULL`, even if we don't really claim that things can be re-init'd)
  
  Testing Done:
  Compiled, and ran tests in valgrind.
  
  Reviewed at https://reviews.imfreedom.org/r/2369/

Use Adwaita widgets for basic request entries

• Mon, 20 Mar 2023 23:06:42 -0500
• by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Mon, 20 Mar 2023 23:06:42 -0500] rev 42171
• Use Adwaita widgets for basic request entries
  
  This uses `AdwEntryRow` and `AdwPasswordEntryRow` for text. Also, even though I kept it working in /r/2355, this drops username completion, as `GtkEntryCompletion` is not supported for `AdwEntryRow` and is also deprecated in GTK 4.10.
  
  For multiline entries, `AdwEntryRow` doesn't support it, but I managed to create a mostly similar look to the single line entries. I didn't bother with making the title large when the entry is empty and unfocused, as Adwaita does a whole animation thing that I don't want to copy from them.
  
  Integer fields did not really change, but we'll want to use [`AdwSpinRow`](https://gitlab.gnome.org/GNOME/libadwaita/-/merge_requests/612) when that's complete.
  
  Testing Done:
  Opened Request Fields from Demo protocol.
  
  Reviewed at https://reviews.imfreedom.org/r/2365/

Use GPtrArray internally to PurpleRequest{Group,Page}

• Mon, 20 Mar 2023 23:04:04 -0500
• by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Mon, 20 Mar 2023 23:04:04 -0500] rev 42170
• Use GPtrArray internally to PurpleRequest{Group,Page}
  
  Now that we don't export a `GList`, we can use these arrays internally.
  
  Testing Done:
  Opened Request Fields from Demo protocol, and confirmed all groups/fields were there.
  
  Reviewed at https://reviews.imfreedom.org/r/2364/

Remove unused API from request fields

• Mon, 20 Mar 2023 23:01:54 -0500
• by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Mon, 20 Mar 2023 23:01:54 -0500] rev 42169
• Remove unused API from request fields
  
  The `GList` API is no longer used, as containers use the `GListModel` interface.
  
  Fetching the group-from-field or page-from-group is no longer needed as previous users now process the field along with the group they were already using.
  
  Testing Done:
  Compiled only.
  
  Reviewed at https://reviews.imfreedom.org/r/2363/

Wrap Request Fields dialog in Adwaita widgets

• Mon, 20 Mar 2023 22:59:41 -0500
• by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Mon, 20 Mar 2023 22:59:41 -0500] rev 42168
• Wrap Request Fields dialog in Adwaita widgets
  
  This is the straightforward conversion of simply putting the existing widgets in corresponding `AdwActionRow`. All the different field types are not yet changed.
  
  As an example, I have converted the boolean field to a `GtkSwitch`.
  
  Testing Done:
  Compiled and opened Request Fields from the Demo protocol.
  
  Reviewed at https://reviews.imfreedom.org/r/2355/

Remove PurpleProtocolClient->tooltip_text as it is barely used and we're scaling back our tooltip usage

• Mon, 20 Mar 2023 22:28:16 -0500
• by Gary Kramlich <grim@reaperworld.com> [Mon, 20 Mar 2023 22:28:16 -0500] rev 42167
• Remove PurpleProtocolClient->tooltip_text as it is barely used and we're scaling back our tooltip usage
  
  Testing Done:
  Compiled
  
  Reviewed at https://reviews.imfreedom.org/r/2370/