changelog
- Sun, 29 Jan 2023 12:05:48 -0600
- by Gary Kramlich <grim@reaperworld.com> [Sun, 29 Jan 2023 12:05:48 -0600] rev 42039
- Remove PURPLE_STATIC_ASSERT which is no longer used by anything
Testing Done:
Ran the unit tests and grepped the code base.
Reviewed at https://reviews.imfreedom.org/r/2215/
- Sun, 29 Jan 2023 12:04:06 -0600
- by Gary Kramlich <grim@reaperworld.com> [Sun, 29 Jan 2023 12:04:06 -0600] rev 42038
- Make purple_proxy_get_handle private
This handle is only used internally to the proxy code, so remove it from the
public api.
Testing Done:
Compiled
Reviewed at https://reviews.imfreedom.org/r/2220/
- Tue, 24 Jan 2023 15:40:35 -0600
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Tue, 24 Jan 2023 15:40:35 -0600] rev 42037
- Convert XmppDiscoService into a GObject
This will enable porting things to binding/expression lookup.
I probably didn't _really_ need to make everything properties, but that was easier to do than figure out which ones would really be needed.
Testing Done:
Ran discovery on `pidgin.im`; saw `conference.pidgin.im` show up, then expanded it and the various rooms appeared, as they should. Clicked Add on a few and verified that the Add Chat dialog appeared with the correct values.
Reviewed at https://reviews.imfreedom.org/r/2210/
- Mon, 23 Jan 2023 23:27:47 -0600
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Mon, 23 Jan 2023 23:27:47 -0600] rev 42036
- Port the room list from GtkTreeView to GtkColumnView
Note, this removes the tooltip. It's not super easy to get the cell that the mouse is over, plus all it showed was the Name, which is pretty redundant.
It also removes the popup menu, for the same reason, as it just duplicates the response buttons, and on a `ColumnView`, right-clicking does not select the hovered row anyway.
Testing Done:
Fetched room list for `conference.pidgin.im`, clicked on the rows, and saw that the buttons were enabled (though I think all responses were chats so they were always enabled once one was selected.) Typed some bit of the names and they were filtered.
Reviewed at https://reviews.imfreedom.org/r/2209/
- Mon, 23 Jan 2023 20:55:34 -0600
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Mon, 23 Jan 2023 20:55:34 -0600] rev 42035
- Remove unused enums from Pidgin
None of the listed headers define any public & used enums, so they can be removed from the Meson list.
But actually, none of the headers in Pidgin define any enums, so remove the whole `pidginenums.h`. We can re-add it later if needed.
Testing Done:
Compiled only.
Reviewed at https://reviews.imfreedom.org/r/2208/
- Mon, 23 Jan 2023 20:51:42 -0600
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Mon, 23 Jan 2023 20:51:42 -0600] rev 42034
- Use icon-name to set up XMPP Discovery icons instead
This will make it easier to move away from `GtkTreeView`.
Testing Done:
Fetched discovery results from `pidgin.im` and the entries had icons (though I think only chats exist on there.)
Reviewed at https://reviews.imfreedom.org/r/2207/
- Sat, 21 Jan 2023 22:49:50 -0600
- by Gary Kramlich <grim@reaperworld.com> [Sat, 21 Jan 2023 22:49:50 -0600] rev 42033
- Move back to gsasl 1.8.0
We don't need anything specific in 1.10.0 and OpenBSD only has 1.8.1.
Testing Done:
Configured locally.
Reviewed at https://reviews.imfreedom.org/r/2206/
- Sat, 21 Jan 2023 22:47:48 -0600
- by Gary Kramlich <grim@reaperworld.com> [Sat, 21 Jan 2023 22:47:48 -0600] rev 42032
- Remove the remaining nat-pmp code for auto discovering ip addresses
Testing Done:
Compiled
Reviewed at https://reviews.imfreedom.org/r/2161/
- Sat, 21 Jan 2023 22:45:30 -0600
- by Gary Kramlich <grim@reaperworld.com> [Sat, 21 Jan 2023 22:45:30 -0600] rev 42031
- Remove the TURN stuff as it didn't do much and is going to move to Traversity
Testing Done:
Compiled and verified the network preferences page still functioned properly.
Reviewed at https://reviews.imfreedom.org/r/2160/
- Fri, 20 Jan 2023 05:24:44 -0600
- by Gary Kramlich <grim@reaperworld.com> [Fri, 20 Jan 2023 05:24:44 -0600] rev 42030
- Make PurpleIRCv3Connection Derivable
This is going to be necessary for the protocol plugin to be subclassed.
Testing Done:
Compiled and connected to my local ergo instance.
Reviewed at https://reviews.imfreedom.org/r/2187/
