changelog
- Fri, 23 Sep 2022 03:47:08 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 23 Sep 2022 03:47:08 -0500] rev 41739
- Create the new PurpleContact
Testing Done:
Ran the unit tests and `ninja pidgin-pot`
Bugs closed: PIDGIN-17663
Reviewed at https://reviews.imfreedom.org/r/1828/
- Fri, 23 Sep 2022 03:44:40 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 23 Sep 2022 03:44:40 -0500] rev 41738
- Revert the wrap-file change as it breaks our ability to use gi-docgen with subprojects
Using wrap-file causes the build directory to have the first path from the archive that was extracted. Normally this isn't a problem, but to use `gi-docgen` with our subproject we need to a `--add-include-dir` to `gi-docgen` which means we need to have a known path. These directories with the version number in them would then have to be updated for every `gi-docgen` call every time we update one of these dependencies.
This is a nightmare, so for the packages we do this for, we will continue using `wrap-hg` or `wrap-git` so that can can control the name of the directory for the subproject in the build directory.
Testing Done:
Build the docs many times while making sure my `$topsrcdir/subprojects` directory only had wrap files.
Reviewed at https://reviews.imfreedom.org/r/1830/
- Fri, 23 Sep 2022 01:23:57 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 23 Sep 2022 01:23:57 -0500] rev 41737
- Remove extraneous scrolled window in account editor
The AdwPreferencesPage already contains a scrolled window.
Testing Done:
Opened the account editor, which was still scrollable.
Reviewed at https://reviews.imfreedom.org/r/1829/
- Fri, 23 Sep 2022 00:13:38 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 23 Sep 2022 00:13:38 -0500] rev 41736
- Create the PurpleTags object for handling tags
Testing Done:
Ran the unit tests.
Bugs closed: PIDGIN-17664
Reviewed at https://reviews.imfreedom.org/r/1777/
- Thu, 22 Sep 2022 23:26:05 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 22 Sep 2022 23:26:05 -0500] rev 41735
- Fix the purplepath unit tests by setting up the test ui and fixing the paths we validate
Testing Done:
Ran the tests.
Reviewed at https://reviews.imfreedom.org/r/1827/
- Thu, 22 Sep 2022 22:26:57 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 22 Sep 2022 22:26:57 -0500] rev 41734
- Clean up setting handling for the credential manager and make its unit tests don't mess up the others
Testing Done:
removed `build/libpurple/tests/config` and ran the unit tests. the `purple path` tests are still failing, but that's unrelated.
Reviewed at https://reviews.imfreedom.org/r/1826/
- Thu, 22 Sep 2022 20:25:37 -0500
- by Gary Kramlich <grim@reaperworld.com> [Thu, 22 Sep 2022 20:25:37 -0500] rev 41733
- Rename PurpleContact to PurpleMetaContact.
This is to help facilitate the new blist api that's still being designed but we
wanted to use this name for an object. A later review request will rename
contact.[ch] which was avoided for now as it would make the diff harder to read.
Testing Done:
Ran and verified that contacts showed up.
Reviewed at https://reviews.imfreedom.org/r/1770/
- Wed, 21 Sep 2022 03:27:36 -0500
- by Gary Kramlich <grim@reaperworld.com> [Wed, 21 Sep 2022 03:27:36 -0500] rev 41732
- Move all the wrap files to use wrap-file instead of wrap-git and wrap-hg
Testing Done:
ran the following command too many times making sure everything still worked.
```
meson subprojects purge --confirm ; rm -rf build && meson build -Dbuild-dependencies=true -Dwrap_mode=forcefallback
```
Reviewed at https://reviews.imfreedom.org/r/1799/
- Wed, 21 Sep 2022 03:24:41 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Wed, 21 Sep 2022 03:24:41 -0500] rev 41731
- De-privatize PurpleSqliteHistoryAdapter
Testing Done:
Compile only.
Reviewed at https://reviews.imfreedom.org/r/1825/
- Wed, 21 Sep 2022 03:22:51 -0500
- by Gary Kramlich <grim@reaperworld.com> [Wed, 21 Sep 2022 03:22:51 -0500] rev 41730
- Use the id property of PurpleUiInfo as the directory name to use with XDG_CONFIG_HOME
Testing Done:
Ran both finch and pidgin.
Verified that they created `build/config/finch3` and `build/config/pidgin3` when run from a devenv environment.
Also verified that `gtk-gaim.ini` in `build/config/pidgin3` was no named `build/config/pidgin3/pidgin3.ini`.
Reviewed at https://reviews.imfreedom.org/r/1824/
