changelog
- Fri, 04 Nov 2022 23:41:10 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 04 Nov 2022 23:41:10 -0500] rev 41888
- Take advantage of f-strings in Meson
They were added in 0.58, which is our minimum version
https://mesonbuild.com/Syntax.html#format-strings
Testing Done:
Reconfigured, ran tests, and checked a few generated files to be sure they looked okay.
Reviewed at https://reviews.imfreedom.org/r/2033/
- Fri, 04 Nov 2022 23:06:10 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 04 Nov 2022 23:06:10 -0500] rev 41887
- Build against libsoup3 by default
This follows the [recommendations from upstream](https://discourse.gnome.org/t/please-build-against-libsoup-3-by-default/10190/3). Note that this changes the option name from `soup3` to `soup2`.
Testing Done:
Compiled against libsoup3 and libsoup2.
Reviewed at https://reviews.imfreedom.org/r/2028/
- Fri, 04 Nov 2022 23:03:08 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 04 Nov 2022 23:03:08 -0500] rev 41886
- Port the rest of gg to libsoup3
However, I did not implement sending files, as libsoup requires a `GInputStream`, and that's some work to set up in a streaming manner. As we want to move the file transfer stuff to GIO, I think we'd wait to do that fully until then.
Testing Done:
Compiled with libsoup2 and with libsoup3.
Reviewed at https://reviews.imfreedom.org/r/2026/
- Fri, 04 Nov 2022 04:04:22 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 04 Nov 2022 04:04:22 -0500] rev 41885
- Remove some unused function from the windows specific code and fix a warning as well
Testing Done:
Compiled and ran on windows
Reviewed at https://reviews.imfreedom.org/r/2025/
- Fri, 04 Nov 2022 04:00:14 -0500
- by Gary Kramlich <grim@reaperworld.com> [Fri, 04 Nov 2022 04:00:14 -0500] rev 41884
- Add async function to PurpleProtocol for testing whether or not connections are possible
This is intended to be used by the connection manager to attempt to
intelligently connect accounts.
Testing Done:
Ran the unit tests and forced them to fail as well.
Reviewed at https://reviews.imfreedom.org/r/2024/
- Fri, 04 Nov 2022 02:32:53 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 04 Nov 2022 02:32:53 -0500] rev 41883
- Fix string size specifier in debug prints
The `%*s` specifies the *width* of the string, but this was intended to specify
the maximum number of characters (in case the `GBytes` was unterminated), which is `%.*s`.
Testing Done:
Compiled only, though I did write a small test program with `printf` to confirm that this worked the intended way.
Reviewed at https://reviews.imfreedom.org/r/2023/
- Fri, 04 Nov 2022 00:47:21 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 04 Nov 2022 00:47:21 -0500] rev 41882
- Remove last unused argument in purple_util_format_song_info
Testing Done:
Compiled only.
Reviewed at https://reviews.imfreedom.org/r/2020/
- Fri, 04 Nov 2022 00:20:18 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Fri, 04 Nov 2022 00:20:18 -0500] rev 41881
- Fix error parameter annotations
The `(optional)` annotation causes a warning because the parameter is not marked as `(out)`. Additionally, the annotations have no effect on the generated documentation.
When a function takes `GError **error`, then the GObject introspection data includes `throws="1"`.
When gi-docgen sees that annotation, it inserts a standard text about it, so what we write there doesn't matter too much. It will only be seen by people reading the header file directly, so I have inserted a consistent text in those places.
Testing Done:
Compiled and saw fewer warnings from gobject-introspection.
Reviewed at https://reviews.imfreedom.org/r/2019/
- Thu, 03 Nov 2022 22:53:41 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Thu, 03 Nov 2022 22:53:41 -0500] rev 41880
- Fix SoupMessage leaks when using new libsoup3 API
The new API takes a ref, not ownership, of the sent message, so we need to unref our copy.
The compatibility layer for libsoup2 similarly also takes a ref, so this is also leaking on libsoup2 now.
Also fix an incorrect data parameter in the gnttinyurl plugin (all the rest of the code was already changed expecting `msg` as the callback data.)
Testing Done:
Compile only.
Reviewed at https://reviews.imfreedom.org/r/2017/
- Thu, 03 Nov 2022 22:52:46 -0500
- by Elliott Sales de Andrade <quantum.analyst@gmail.com> [Thu, 03 Nov 2022 22:52:46 -0500] rev 41879
- De-privatize more Facebook internals
I have no idea why I didn't do these in /r/1822.
Testing Done:
Compile only.
Reviewed at https://reviews.imfreedom.org/r/2016/
