Mercurial > pidgin3 / changeset

--- a/libpurple/plugins/wincred/wincred.c	Thu Nov 21 21:41:35 2024 -0600
+++ b/libpurple/plugins/wincred/wincred.c	Thu Nov 21 22:12:24 2024 -0600
@@ -60,17 +60,14 @@
 static gunichar2 *
 wincred_get_target_name(PurpleAccount *account, GError **error)
 {
-	PurpleContactInfo *info = NULL;
 	gchar target_name_utf8[WINCRED_MAX_TARGET_NAME];
 	gunichar2 *target_name_utf16;
 
 	g_return_val_if_fail(PURPLE_IS_ACCOUNT(account), NULL);
 
-	info = PURPLE_CONTACT_INFO(account);
-
 	g_snprintf(target_name_utf8, WINCRED_MAX_TARGET_NAME, "libpurple_%s_%s",
 		purple_account_get_protocol_id(account),
-		purple_contact_info_get_username(info));
+		purple_account_get_username(account));
 
 	target_name_utf16 =
 	        g_utf8_to_utf16(target_name_utf8, -1, NULL, NULL, error);
@@ -110,10 +107,9 @@
 
 		if (error_code == ERROR_NOT_FOUND) {
 			if (purple_debug_is_verbose()) {
-				PurpleContactInfo *info = PURPLE_CONTACT_INFO(account);
 				purple_debug_misc("keyring-wincred",
 				                  "No password found for account %s\n",
-				                  purple_contact_info_get_username(info));
+				                  purple_account_get_username(account));
 			}
 			error = g_error_new(PURPLE_WINCRED_ERROR,
 				error_code,
@@ -157,10 +153,9 @@
 		g_object_unref(task);
 		return;
 	} else {
-		PurpleContactInfo *info = PURPLE_CONTACT_INFO(account);
 		purple_debug_misc("keyring-wincred",
 		                  _("Got password for account %s.\n"),
-		                  purple_contact_info_get_username(info));
+		                  purple_account_get_username(account));
 	}
 
 	g_task_return_pointer(task, password, g_free);
@@ -184,7 +179,6 @@
                                     GCancellable *cancellable,
                                     GAsyncReadyCallback callback, gpointer data)
 {
-	PurpleContactInfo *info = PURPLE_CONTACT_INFO(account);
 	GTask *task = NULL;
 	GError *error = NULL;
 	const char *username_utf8 = NULL;
@@ -204,7 +198,7 @@
 		return;
 	}
 
-	username_utf8 = purple_contact_info_get_username(info);
+	username_utf8 = purple_account_get_username(account);
 	username_utf16 = g_utf8_to_utf16(username_utf8, -1, NULL, NULL, &error);
 	if (username_utf16 == NULL) {
 		g_free(target_name);
@@ -250,7 +244,7 @@
 		}
 	} else {
 		purple_debug_misc("keyring-wincred", "Password updated for account %s.",
-		                  purple_contact_info_get_username(info));
+		                  username_utf8);
 	}
 
 	g_free(target_name);
@@ -297,10 +291,8 @@
 	}
 
 	if (CredDeleteW(target_name, CRED_TYPE_GENERIC, 0)) {
-		PurpleContactInfo *info = PURPLE_CONTACT_INFO(account);
-
 		purple_debug_misc("keyring-wincred", "Password for account %s removed",
-		                  purple_contact_info_get_username(info));
+		                  purple_account_get_username(account));
 		g_task_return_boolean(task, TRUE);
 	} else {
 		DWORD error_code = GetLastError();

--- a/libpurple/purpleaccount.c	Thu Nov 21 21:41:35 2024 -0600
+++ b/libpurple/purpleaccount.c	Thu Nov 21 22:12:24 2024 -0600
@@ -247,15 +247,12 @@
 
 	if(!purple_credential_manager_write_password_finish(manager, res, &error))
 	{
-		PurpleContactInfo *info = PURPLE_CONTACT_INFO(account);
-		const char *name = purple_contact_info_get_name_for_display(info);
-
 		/* we can't error an account without a connection, so we just drop a
 		 * debug message for now and continue to connect the account.
 		 */
 		purple_debug_info("account",
 		                  "failed to save password for account \"%s\": %s",
-		                  name,
+		                  purple_account_get_username(account),
 		                  error != NULL ? error->message : "unknown error");
 		g_clear_error(&error);
 	}
@@ -1259,7 +1256,7 @@
 	/* Close any previous password request windows */
 	purple_request_close_with_handle(account);
 
-	username = purple_contact_info_get_username(PURPLE_CONTACT_INFO(account));
+	username = purple_account_get_username(account);
 	primary = g_strdup_printf(_("Enter password for %s (%s)"), username,
 	                          purple_protocol_get_name(account->protocol));
 
@@ -1762,7 +1759,7 @@
 
 		g_critical("purple_account_settings_thaw_notify called for account %s "
 		           "(%s) when not frozen",
-		           purple_contact_info_get_username(PURPLE_CONTACT_INFO(account)),
+		           purple_account_get_username(account),
 		           purple_account_get_protocol_id(account));
 
 		return;