Thu, 30 Jan 2014 02:53:18 +0530
Merged default branch
--- a/libpurple/conversation.c Thu Jan 30 01:00:51 2014 +0530 +++ b/libpurple/conversation.c Thu Jan 30 02:53:18 2014 +0530 @@ -335,7 +335,7 @@ if (account == purple_conversation_get_account(conv)) return; - purple_conversations_update_cache(conv, NULL, account); + _purple_conversations_update_cache(conv, NULL, account); priv->account = account; g_object_notify_by_pspec(G_OBJECT(conv), properties[PROP_ACCOUNT]); @@ -428,7 +428,7 @@ g_return_if_fail(priv != NULL); - purple_conversations_update_cache(conv, name, NULL); + _purple_conversations_update_cache(conv, name, NULL); g_free(priv->name); priv->name = g_strdup(name);
--- a/libpurple/conversations.c Thu Jan 30 01:00:51 2014 +0530 +++ b/libpurple/conversations.c Thu Jan 30 02:53:18 2014 +0530 @@ -115,7 +115,7 @@ } void -purple_conversations_update_cache(PurpleConversation *conv, const char *name, +_purple_conversations_update_cache(PurpleConversation *conv, const char *name, PurpleAccount *account) { PurpleAccount *old_account;
--- a/libpurple/conversations.h Thu Jan 30 01:00:51 2014 +0530 +++ b/libpurple/conversations.h Thu Jan 30 02:53:18 2014 +0530 @@ -52,18 +52,6 @@ void purple_conversations_remove(PurpleConversation *conv); /** - * Updates the conversation cache to use a new conversation name and/or - * account. This function only updates the conversation cache. It is the - * caller's responsibility to actually update the conversation. - * - * @param conv The conversation. - * @param name The new name. If no change, use @c NULL. - * @param account The new account. If no change, use @c NULL. - */ -void purple_conversations_update_cache(PurpleConversation *conv, - const char *name, PurpleAccount *account); - -/** * Returns a list of all conversations. * * This list includes both IMs and chats.
--- a/libpurple/internal.h Thu Jan 30 01:00:51 2014 +0530 +++ b/libpurple/internal.h Thu Jan 30 02:53:18 2014 +0530 @@ -262,6 +262,21 @@ PurpleChatConversation *chat); /** + * Updates the conversation cache to use a new conversation name and/or + * account. This function only updates the conversation cache. It is the + * caller's responsibility to actually update the conversation. + * + * @note This function should only be called by purple_conversation_set_name() + * and purple_conversation_set_account() in conversation.c. + * + * @param conv The conversation. + * @param name The new name. If no change, use @c NULL. + * @param account The new account. If no change, use @c NULL. + */ +void _purple_conversations_update_cache(PurpleConversation *conv, + const char *name, PurpleAccount *account); + +/** * Returns the primitive scores array from status.c. * * @note This function should only be called by
--- a/libpurple/plugins/perl/common/Conversation.xs Thu Jan 30 01:00:51 2014 +0530 +++ b/libpurple/plugins/perl/common/Conversation.xs Thu Jan 30 02:53:18 2014 +0530 @@ -90,12 +90,6 @@ purple_conversations_remove(conv) Purple::Conversation conv -void -purple_conversations_update_cache(conv, name, account) - Purple::Conversation conv - const char * name - Purple::Account account - Purple::Handle purple_conversations_get_handle()