Sun, 17 Nov 2013 04:06:49 +0530
ciphers: Use G_PARAM_STATIC_STRINGS and ensure g_object_notify is always called
--- a/libpurple/ciphers/aescipher.c Sun Nov 17 03:37:28 2013 +0530 +++ b/libpurple/ciphers/aescipher.c Sun Nov 17 04:06:49 2013 +0530 @@ -505,11 +505,12 @@ { PurpleAESCipherPrivate *priv = PURPLE_AES_CIPHER_GET_PRIVATE(cipher); - if (mode == PURPLE_CIPHER_BATCH_MODE_CBC) - return; + if (mode != PURPLE_CIPHER_BATCH_MODE_CBC) { + purple_debug_error("cipher-aes", "unsupported batch mode\n"); + priv->failure = TRUE; + } - purple_debug_error("cipher-aes", "unsupported batch mode\n"); - priv->failure = TRUE; + g_object_notify(G_OBJECT(cipher), "batch-mode"); } static PurpleCipherBatchMode @@ -590,17 +591,17 @@ cipher_class->get_batch_mode = purple_aes_cipher_get_batch_mode; cipher_class->get_block_size = purple_aes_cipher_get_block_size; - pspec = g_param_spec_enum("batch_mode", "batch_mode", "batch_mode", + pspec = g_param_spec_enum("batch-mode", "batch-mode", "batch-mode", PURPLE_TYPE_CIPHER_BATCH_MODE, 0, - G_PARAM_READWRITE); + G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_BATCH_MODE, pspec); pspec = g_param_spec_string("iv", "iv", "iv", NULL, - G_PARAM_WRITABLE); + G_PARAM_WRITABLE | G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_IV, pspec); pspec = g_param_spec_string("key", "key", "key", NULL, - G_PARAM_WRITABLE); + G_PARAM_WRITABLE | G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_KEY, pspec); g_type_class_add_private(klass, sizeof(PurpleAESCipherPrivate));
--- a/libpurple/ciphers/des3cipher.c Sun Nov 17 03:37:28 2013 +0530 +++ b/libpurple/ciphers/des3cipher.c Sun Nov 17 04:06:49 2013 +0530 @@ -352,6 +352,8 @@ PurpleDES3CipherPrivate *priv = PURPLE_DES3_CIPHER_GET_PRIVATE(des3_cipher); priv->mode = mode; + + g_object_notify(G_OBJECT(cipher), "batch-mode"); } static PurpleCipherBatchMode @@ -456,17 +458,17 @@ cipher_class->get_batch_mode = purple_des3_cipher_get_batch_mode; cipher_class->get_key_size = purple_des3_cipher_get_key_size; - pspec = g_param_spec_enum("batch_mode", "batch_mode", "batch_mode", + pspec = g_param_spec_enum("batch-mode", "batch-mode", "batch-mode", PURPLE_TYPE_CIPHER_BATCH_MODE, 0, - G_PARAM_READWRITE); + G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_BATCH_MODE, pspec); pspec = g_param_spec_string("iv", "iv", "iv", NULL, - G_PARAM_WRITABLE); + G_PARAM_WRITABLE | G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_IV, pspec); pspec = g_param_spec_string("key", "key", "key", NULL, - G_PARAM_WRITABLE); + G_PARAM_WRITABLE | G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_KEY, pspec); g_type_class_add_private(klass, sizeof(PurpleDES3CipherPrivate));
--- a/libpurple/ciphers/descipher.c Sun Nov 17 03:37:28 2013 +0530 +++ b/libpurple/ciphers/descipher.c Sun Nov 17 04:06:49 2013 +0530 @@ -534,7 +534,7 @@ cipher_class->get_key_size = purple_des_cipher_get_key_size; pspec = g_param_spec_string("key", "key", "key", NULL, - G_PARAM_WRITABLE); + G_PARAM_WRITABLE | G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_KEY, pspec); g_type_class_add_private(klass, sizeof(PurpleDESCipherPrivate));
--- a/libpurple/ciphers/hmaccipher.c Sun Nov 17 03:37:28 2013 +0530 +++ b/libpurple/ciphers/hmaccipher.c Sun Nov 17 04:06:49 2013 +0530 @@ -280,7 +280,8 @@ cipher_class->get_block_size = purple_hmac_cipher_get_block_size; pspec = g_param_spec_object("hash", "hash", "hash", PURPLE_TYPE_HASH, - G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY); + G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | + G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_HASH, pspec); }
--- a/libpurple/ciphers/pbkdf2cipher.c Sun Nov 17 03:37:28 2013 +0530 +++ b/libpurple/ciphers/pbkdf2cipher.c Sun Nov 17 04:06:49 2013 +0530 @@ -337,15 +337,18 @@ cipher_class->set_key = purple_pbkdf2_cipher_set_key; pspec = g_param_spec_object("hash", "hash", "hash", PURPLE_TYPE_HASH, - G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY); + G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY | + G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_HASH, pspec); - pspec = g_param_spec_uint("iter_count", "iter_count", "iter_count", 0, - G_MAXUINT, 0, G_PARAM_READWRITE); + pspec = g_param_spec_uint("iter-count", "iter-count", "iter-count", 0, + G_MAXUINT, 0, G_PARAM_READWRITE | + G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_ITER_COUNT, pspec); - pspec = g_param_spec_uint("out_len", "out_len", "out_len", 0, - G_MAXUINT, 0, G_PARAM_READWRITE); + pspec = g_param_spec_uint("out-len", "out-len", "out-len", 0, + G_MAXUINT, 0, G_PARAM_READWRITE | + G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_OUT_LEN, pspec); g_type_class_add_private(klass, sizeof(PurplePBKDF2CipherPrivate));
--- a/libpurple/ciphers/rc4cipher.c Sun Nov 17 03:37:28 2013 +0530 +++ b/libpurple/ciphers/rc4cipher.c Sun Nov 17 04:06:49 2013 +0530 @@ -180,13 +180,13 @@ cipher_class->encrypt = purple_rc4_cipher_encrypt; cipher_class->set_key = purple_rc4_cipher_set_key; - pspec = g_param_spec_int("key_len", "key_len", "key_len", + pspec = g_param_spec_int("key-len", "key-len", "key-len", G_MININT, G_MAXINT, 0, - G_PARAM_READWRITE); + G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_KEY_LEN, pspec); pspec = g_param_spec_string("key", "key", "key", NULL, - G_PARAM_WRITABLE); + G_PARAM_WRITABLE | G_PARAM_STATIC_STRINGS); g_object_class_install_property(obj_class, PROP_KEY, pspec); g_type_class_add_private(klass, sizeof(PurpleRC4CipherPrivate)); @@ -241,6 +241,8 @@ priv = PURPLE_RC4_CIPHER_GET_PRIVATE(rc4_cipher); priv->key_len = key_len; + + g_object_notify(G_OBJECT(rc4_cipher), "key-len"); } gint