Mercurial > pidgin3 / changeset

• changeset
• raw

changeset

Fix some issues scanbuild found in the silc protocol plugin release-2.x.y

Wed, 02 Jun 2021 02:59:43 -0500

author

Gary Kramlich <grim@reaperworld.com>

date

Wed, 02 Jun 2021 02:59:43 -0500

branch

release-2.x.y

changeset 40918

40211e37a935

parent 40917

40d6cd6dc56d

child 40919

8924ad9e86c4

Fix some issues scanbuild found in the silc protocol plugin

Testing Done:
Verified that scanbuild no longer detected the errors.

Reviewed at https://reviews.imfreedom.org/r/712/

--- a/libpurple/protocols/silc/ops.c	Wed Jun 02 02:59:18 2021 -0500
+++ b/libpurple/protocols/silc/ops.c	Wed Jun 02 02:59:43 2021 -0500
@@ -222,7 +222,6 @@
 					    tmp, cflags, time(NULL));
 
 			purple_imgstore_unref_by_id(imgid);
-			cflags = 0;
 			ret = TRUE;
 		}
 		goto out;