Free strings received from g_object_get soc.2013.gobjectification

Sun, 14 Jul 2013 15:08:50 +0530

author
Ankit Vani <a@nevitus.org>
date
Sun, 14 Jul 2013 15:08:50 +0530
branch
soc.2013.gobjectification
changeset 34769
427725f8ed54
parent 34768
d193657a4b37
child 34770
e325d5320b27

Free strings received from g_object_get

libpurple/account.c file | annotate | diff | comparison | revisions
libpurple/buddylist.c file | annotate | diff | comparison | revisions
libpurple/conversationtypes.c file | annotate | diff | comparison | revisions
pidgin/gtkblist.c file | annotate | diff | comparison | revisions
pidgin/gtkutils.c file | annotate | diff | comparison | revisions
--- a/libpurple/account.c	Sun Jul 14 14:39:48 2013 +0530
+++ b/libpurple/account.c	Sun Jul 14 15:08:50 2013 +0530
@@ -2921,8 +2921,11 @@
 			account);
 
 	prpl = purple_find_prpl(protocol_id);
-	if (prpl == NULL)
+	if (prpl == NULL) {
+		g_free(username);
+		g_free(protocol_id);
 		return;
+	}
 
 	prpl_info = PURPLE_PLUGIN_PROTOCOL_INFO(prpl);
 	if (prpl_info != NULL && prpl_info->status_types != NULL)
@@ -2941,6 +2944,9 @@
 		purple_presence_set_status_active(priv->presence,
 										"offline",
 										TRUE);
+
+	g_free(username);
+	g_free(protocol_id);
 }
 
 /* GObject dispose function */
--- a/libpurple/buddylist.c	Sun Jul 14 14:39:48 2013 +0530
+++ b/libpurple/buddylist.c	Sun Jul 14 15:08:50 2013 +0530
@@ -237,6 +237,7 @@
 	g_hash_table_foreach(purple_blist_node_get_settings(PURPLE_BLIST_NODE(contact)),
 			value_to_xmlnode, node);
 
+	g_free(alias);
 	return node;
 }
 
@@ -267,6 +268,7 @@
 	g_hash_table_foreach(purple_blist_node_get_settings(PURPLE_BLIST_NODE(chat)),
 			value_to_xmlnode, node);
 
+	g_free(alias);
 	return node;
 }
 
--- a/libpurple/conversationtypes.c	Sun Jul 14 14:39:48 2013 +0530
+++ b/libpurple/conversationtypes.c	Sun Jul 14 15:08:50 2013 +0530
@@ -444,6 +444,8 @@
 
 	if (purple_prefs_get_bool("/purple/logging/log_ims"))
 		purple_conversation_set_logging(PURPLE_CONVERSATION(im), TRUE);
+
+	g_free(name);
 }
 
 /* GObject dispose function */
--- a/pidgin/gtkblist.c	Sun Jul 14 14:39:48 2013 +0530
+++ b/pidgin/gtkblist.c	Sun Jul 14 15:08:50 2013 +0530
@@ -627,6 +627,7 @@
 		purple_chat_set_alias(PURPLE_CHAT(node), arg2);
 	}
 
+	g_free(alias);
 	pidgin_blist_refresh(list);
 }
 
@@ -3921,11 +3922,10 @@
 					purple_account_get_username(purple_buddy_get_account(b)));
 		}
 
-		g_object_get(c, "alias", &alias, NULL);
-
 		/* Alias */
 		/* If there's not a contact alias, the node is being displayed with
 		 * this alias, so there's no point in showing it in the tooltip. */
+		g_object_get(c, "alias", &alias, NULL);
 		if (full && c && purple_buddy_get_local_alias(b) != NULL && purple_buddy_get_local_alias(b)[0] != '\0' &&
 		    (alias != NULL && alias[0] != '\0') &&
 		    strcmp(alias, purple_buddy_get_local_alias(b)) != 0)
@@ -4068,6 +4068,7 @@
 
 		purple_notify_user_info_destroy(user_info);
 	}
+	g_free(alias);
 
 	purple_signal_emit(pidgin_blist_get_handle(), "drawing-tooltip",
 	                   node, str, full);
@@ -4515,6 +4516,7 @@
 	g_free(nametext);
 	g_free(statustext);
 	g_free(idletime);
+	g_free(contact_alias);
 
 	if (hidden_conv) {
 		char *tmp = text;
--- a/pidgin/gtkutils.c	Sun Jul 14 14:39:48 2013 +0530
+++ b/pidgin/gtkutils.c	Sun Jul 14 15:08:50 2013 +0530
@@ -1982,6 +1982,8 @@
 			if (!PURPLE_IS_CONTACT(cnode))
 				continue;
 
+			g_object_get(cnode, "alias", &alias, NULL);
+
 			for (bnode = cnode->child; bnode != NULL; bnode = bnode->next)
 			{
 				PidginBuddyCompletionEntry entry;
@@ -1989,7 +1991,6 @@
 				entry.entry.buddy = (PurpleBuddy *) bnode;
 
 				if (filter_func(&entry, user_data)) {
-					g_object_get(cnode, "alias", &alias, NULL);
 					add_buddyname_autocomplete_entry(data->store,
 														alias,
 														purple_buddy_get_contact_alias(entry.entry.buddy),
@@ -1998,6 +1999,8 @@
 													 );
 				}
 			}
+
+			g_free(alias);
 		}
 	}
 

mercurial