Apparently gcc gives a warning here even though it's perfectly valid

Thu, 17 Jan 2008 07:53:03 +0000

author
Mark Doliner <markdoliner@pidgin.im>
date
Thu, 17 Jan 2008 07:53:03 +0000
changeset 22267
4d0fec285d48
parent 22266
59c7fc65bc16
child 22268
a6f48dec4ca5
child 22271
09b73ef9fd50

Apparently gcc gives a warning here even though it's perfectly valid
and more efficient.

libpurple/protocols/oscar/oscar.c file | annotate | diff | comparison | revisions
--- a/libpurple/protocols/oscar/oscar.c	Thu Jan 17 07:39:25 2008 +0000
+++ b/libpurple/protocols/oscar/oscar.c	Thu Jan 17 07:53:03 2008 +0000
@@ -1789,11 +1789,7 @@
 		purple_prpl_got_user_status_deactive(account, info->sn, OSCAR_STATUS_ID_MOBILE);
 	}
 
-	/*
-	 * It's ok for us to use == instead of strcmp() here because
-	 * status_id is set to one of these #defines a few lines above here.
-	 */
-	if (status_id == OSCAR_STATUS_ID_AVAILABLE)
+	if (strcmp(status_id, OSCAR_STATUS_ID_AVAILABLE) == 0)
 	{
 		char *message = NULL;
 		char *itmsurl = NULL;

mercurial