changeset
[gaim-migrate @ 11978]
Mon, 07 Feb 2005 23:29:48 +0000
- author
- Felipe Contreras <felipe.contreras@gmail.com>
- date
- Mon, 07 Feb 2005 23:29:48 +0000
- changeset 10580
- 5505fba53fba
- parent 10579
- f4576b2e0956
- child 10581
- fec09b96544a
[gaim-migrate @ 11978]
sf patch #1112736, from Felipe Contreras
Fix a thing where we might free a GaimPresence when it is still in use
committer: Mark Doliner <markdoliner@pidgin.im>
| src/status.c | file | annotate | diff | comparison | revisions |
--- a/src/status.c Sun Feb 06 17:40:45 2005 +0000 +++ b/src/status.c Mon Feb 07 23:29:48 2005 +0000 @@ -1169,8 +1169,6 @@ { GaimStatusBuddyKey key; - presence->u.buddy.ref_count--; - if(presence->u.buddy.ref_count != 0) return; @@ -1196,6 +1194,11 @@ g_free(presence); } +/* + * TODO: Maybe we should cal gaim_presence_destroy() after we + * decrement the ref count? I don't see why we should + * make other places do it manually when we can do it here. + */ void gaim_presence_remove_buddy(GaimPresence *presence, GaimBuddy *buddy) {
