changeset
Fix a few issues with the CredentialProvider code that snuck past review
Wed, 14 Oct 2020 23:05:50 -0500
- author
- Gary Kramlich <grim@reaperworld.com>
- date
- Wed, 14 Oct 2020 23:05:50 -0500
- changeset 40561
- 569ab1326932
- parent 40560
- 6af4d993c8e5
- child 40562
- 797f5a0f602c
Fix a few issues with the CredentialProvider code that snuck past review
Testing Done:
Compiled and ran unit tests locally. Verified the warnings were gone from the unit test build and verified the warning was gone from the Purple-3.0.gir build.
Reviewed at https://reviews.imfreedom.org/r/168/
| libpurple/purplecredentialprovider.h | file | annotate | diff | comparison | revisions | |
| libpurple/tests/test_credential_provider.c | file | annotate | diff | comparison | revisions |
--- a/libpurple/purplecredentialprovider.h Wed Oct 14 21:50:38 2020 -0500 +++ b/libpurple/purplecredentialprovider.h Wed Oct 14 23:05:50 2020 -0500 @@ -57,7 +57,7 @@ #define PURPLE_TYPE_CREDENTIAL_PROVIDER (purple_credential_provider_get_type()) G_DECLARE_DERIVABLE_TYPE(PurpleCredentialProvider, purple_credential_provider, - PURPLE, CREDENTIAL_PROVIDER, GObject); + PURPLE, CREDENTIAL_PROVIDER, GObject) /** * PurpleCredentialProviderClass:
--- a/libpurple/tests/test_credential_provider.c Wed Oct 14 21:50:38 2020 -0500 +++ b/libpurple/tests/test_credential_provider.c Wed Oct 14 23:05:50 2020 -0500 @@ -387,6 +387,8 @@ g_main_loop_quit((GMainLoop *)data); g_warning("timed out waiting for the callback function to be called"); + + return FALSE; } static void
