changeset
[gaim-migrate @ 14977]
Fri, 23 Dec 2005 12:02:01 +0000
- author
- Bartosz Oler <bartosz@pidgin.im>
- date
- Fri, 23 Dec 2005 12:02:01 +0000
- changeset 12641
- 62329a68eb7b
- parent 12640
- 1fb40d5d76e7
- child 12642
- dcbc8245a156
[gaim-migrate @ 14977]
A change from Bartosz Oler. I think this is intended to hide blocked as a status that one can set on themself. Anyway, this is all wrong, so I added some comments to that effect.
committer: Richard Laager <rlaager@pidgin.im>
| src/protocols/gg/gg.c | file | annotate | diff | comparison | revisions |
--- a/src/protocols/gg/gg.c Fri Dec 23 06:48:27 2005 +0000 +++ b/src/protocols/gg/gg.c Fri Dec 23 12:02:01 2005 +0000 @@ -1452,9 +1452,10 @@ NULL); types = g_list_append(types, type); - /* Why is blocked a status??? -- rlaager */ + /* This status is wrong. It shouldn't exist. This prpl must not be + * using the privacy stuff correctly. -- rlaager */ type = gaim_status_type_new_with_attrs( - GAIM_STATUS_INVISIBLE, "blocked", _("Blocked"), TRUE, TRUE, FALSE, + GAIM_STATUS_INVISIBLE, "blocked", _("Blocked"), TRUE, FALSE, FALSE, "message", _("Message"), gaim_value_new(GAIM_TYPE_STRING), NULL); types = g_list_append(types, type); @@ -1475,6 +1476,9 @@ ggp_bmenu_add_to_chat, NULL, NULL); m = g_list_append(m, act); + /* Using a blist node boolean here is also wrong. + * Once the Block and Unblock actions are added to the core, + * this will have to go. -- rlaager */ if (gaim_blist_node_get_bool(node, "blocked")) { act = gaim_blist_node_action_new(_("Unblock"), ggp_bmenu_block, NULL, NULL);
