Pass the handle in here, which causes the connection attempt to be

Thu, 18 Jun 2009 23:31:38 +0000

author
Mark Doliner <markdoliner@pidgin.im>
date
Thu, 18 Jun 2009 23:31:38 +0000
changeset 27342
7ae07a1d4bf4
parent 27341
5a964f9c7cdc
child 27343
8a367ee70456

Pass the handle in here, which causes the connection attempt to be
canceled and freed if the gc is destroyed, eliminating the need
for PURPLE_CONNECTION_IS_VALID

libpurple/protocols/oscar/oscar.c file | annotate | diff | comparison | revisions
--- a/libpurple/protocols/oscar/oscar.c	Thu Jun 18 22:40:12 2009 +0000
+++ b/libpurple/protocols/oscar/oscar.c	Thu Jun 18 23:31:38 2009 +0000
@@ -1833,13 +1833,6 @@
 	gchar *buf;
 	gssize result;
 
-	if (!PURPLE_CONNECTION_IS_VALID(pos->gc))
-	{
-		g_free(pos->modname);
-		g_free(pos);
-		return;
-	}
-
 	pos->fd = source;
 
 	if (source < 0) {
@@ -1937,8 +1930,7 @@
 	pos->len = len;
 	pos->modname = g_strdup(modname);
 
-	/* TODO: Keep track of this return value. */
-	if (purple_proxy_connect(NULL, pos->gc->account, "pidgin.im", 80,
+	if (purple_proxy_connect(pos->gc, pos->gc->account, "pidgin.im", 80,
 			straight_to_hell, pos) == NULL)
 	{
 		char buf[256];

mercurial