For XMPP multi-selection lists in generic data forms, the intent here

Tue, 31 Jul 2007 16:11:21 +0000

author
Mark Doliner <markdoliner@pidgin.im>
date
Tue, 31 Jul 2007 16:11:21 +0000
changeset 19051
b932fc2e28cd
parent 19050
78ed2f8cd58d
child 19052
5f49fa1c6f08

For XMPP multi-selection lists in generic data forms, the intent here
was to use the option value as the label in the event that the label
wasn't specified, but the wrong variable was being set. This probably
happens only very rarely, because the label is pretty much always set.

In fact, it wouldn't suprise me if this has never happened.

libpurple/protocols/jabber/xdata.c file | annotate | diff | comparison | revisions
--- a/libpurple/protocols/jabber/xdata.c	Tue Jul 31 06:51:29 2007 +0000
+++ b/libpurple/protocols/jabber/xdata.c	Tue Jul 31 16:11:21 2007 +0000
@@ -256,7 +256,7 @@
 					continue;
 
 				if(!(lbl = xmlnode_get_attrib(optnode, "label")))
-					label = value;
+					lbl = value;
 
 				data->values = g_slist_prepend(data->values, value);
 

mercurial