Fix what looks like an incorrect merge that caused gevolution's add buddy dialog

Sat, 29 Aug 2009 02:31:33 +0000

author
Paul Aurich <darkrain42@pidgin.im>
date
Sat, 29 Aug 2009 02:31:33 +0000
changeset 28391
bde9215d656e
parent 28390
5c701ddc9c81
child 28392
4f4042de6782

Fix what looks like an incorrect merge that caused gevolution's add buddy dialog
to segfault.

UPDATE:

Fix reversed logic in the gevolution plugin that led to a crash. Fixes #10115.

pidgin/plugins/gevolution/gevo-util.c file | annotate | diff | comparison | revisions
--- a/pidgin/plugins/gevolution/gevo-util.c	Fri Aug 28 05:35:00 2009 +0000
+++ b/pidgin/plugins/gevolution/gevo-util.c	Sat Aug 29 02:31:33 2009 +0000
@@ -35,14 +35,16 @@
 
 	conv = purple_find_conversation_with_account(PURPLE_CONV_TYPE_IM, buddy_name, account);
 
-	if ((group = purple_find_group(group_name)) == NULL)
+	group = purple_find_group(group_name);
+	if (group == NULL)
 	{
 		group = purple_group_new(group_name);
 		purple_blist_add_group(group, NULL);
 	}
 
-	if ((buddy = purple_find_buddy_in_group(account, buddy_name, group)))
-	{	
+	buddy = purple_find_buddy_in_group(account, buddy_name, group);
+	if (buddy == NULL)
+	{
 		buddy = purple_buddy_new(account, buddy_name, alias);
 		purple_blist_add_buddy(buddy, NULL, group, NULL);
 	}

mercurial