Just comment out the failing tests when using glib; it's not likely anyone

Sat, 19 Sep 2009 02:36:04 +0000

author
Paul Aurich <darkrain42@pidgin.im>
date
Sat, 19 Sep 2009 02:36:04 +0000
changeset 28558
dd11e7078db9
parent 28554
a4a6df1d2e53
child 28559
10fdaf33744f

Just comment out the failing tests when using glib; it's not likely anyone
will encounter an issue with this in the real world, and it means people
without libidn can run "make check" to find other issues.

libpurple/tests/test_jabber_jutil.c file | annotate | diff | comparison | revisions
--- a/libpurple/tests/test_jabber_jutil.c	Fri Sep 18 06:04:34 2009 +0000
+++ b/libpurple/tests/test_jabber_jutil.c	Sat Sep 19 02:36:04 2009 +0000
@@ -142,13 +142,20 @@
 
 	/* Cyrillic capital EF (U+0424) maps to lowercase EF (U+0444) */
 	assert_jid_parts("ф", "darkrain42.org", "Ф@darkrain42.org");
+
+#ifdef USE_IDN
 	/*
 	 * These character (U+A664 and U+A665) are not mapped to anything in
 	 * RFC3454 B.2. This first test *fails* when not using IDN because glib's
 	 * case-folding/utf8_strdown improperly (for XMPP) lowercases the character.
+	 *
+	 * This is known, but not (very?) likely to actually cause a problem, so
+	 * this test is commented out when using glib's functions.
 	 */
 	assert_jid_parts("Ꙥ", "darkrain42.org", "Ꙥ@darkrain42.org");
 	assert_jid_parts("ꙥ", "darkrain42.org", "ꙥ@darkrain42.org");
+#endif
+
 	/* U+04E9 to U+04E9 */
 	assert_jid_parts("paul", "өarkrain42.org", "paul@Өarkrain42.org");
 }

mercurial